You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2018/10/09 11:08:23 UTC

[GitHub] msumit commented on a change in pull request #4014: [AIRFLOW-3168] add healthcheck for mysql setup in CI

msumit commented on a change in pull request #4014: [AIRFLOW-3168] add healthcheck for mysql setup in CI
URL: https://github.com/apache/incubator-airflow/pull/4014#discussion_r223655917
 
 

 ##########
 File path: scripts/ci/3-setup-databases.sh
 ##########
 @@ -20,4 +20,9 @@ set -exuo pipefail
 
 MYSQL_HOST=mysql
 
+# make sure mysql is done setting up
+while ! mysqladmin ping -h ${MYSQL_HOST} -u root --silent; do
+    sleep 1
+done
 
 Review comment:
   shouldn't the while loop need to exist after some time instead of looping forever?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services