You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/03/18 17:35:00 UTC
[jira] [Work logged] (BEAM-14128) Quadratic behavior in go pipeline rewriting.
[ https://issues.apache.org/jira/browse/BEAM-14128?focusedWorklogId=744267&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-744267 ]
ASF GitHub Bot logged work on BEAM-14128:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Mar/22 17:34
Start Date: 18/Mar/22 17:34
Worklog Time Spent: 10m
Work Description: codecov[bot] commented on pull request #17120:
URL: https://github.com/apache/beam/pull/17120#issuecomment-1072636891
# [Codecov](https://codecov.io/gh/apache/beam/pull/17120?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17120](https://codecov.io/gh/apache/beam/pull/17120?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d73c9de) into [master](https://codecov.io/gh/apache/beam/commit/31ed3311711d64dc5588fea0e555122c4f2cbb4c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (31ed331) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #17120 +/- ##
=======================================
Coverage 73.96% 73.96%
=======================================
Files 671 671
Lines 88221 88223 +2
=======================================
+ Hits 65250 65252 +2
Misses 21859 21859
Partials 1112 1112
```
| Flag | Coverage Δ | |
|---|---|---|
| go | `49.45% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/17120?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [sdks/go/pkg/beam/core/runtime/pipelinex/replace.go](https://codecov.io/gh/apache/beam/pull/17120/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUvcGlwZWxpbmV4L3JlcGxhY2UuZ28=) | `66.19% <100.00%> (+0.24%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/17120?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/17120?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [31ed331...d73c9de](https://codecov.io/gh/apache/beam/pull/17120?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 744267)
Remaining Estimate: 0h
Time Spent: 10m
> Quadratic behavior in go pipeline rewriting.
> --------------------------------------------
>
> Key: BEAM-14128
> URL: https://issues.apache.org/jira/browse/BEAM-14128
> Project: Beam
> Issue Type: Bug
> Components: sdk-go
> Affects Versions: 2.37.0
> Reporter: Robert Burke
> Assignee: Robert Burke
> Priority: P2
> Fix For: 2.38.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Work is repeated for every node outside of a given composite, when checking if anything is using any outputs of transforms internal to the composite.
> This bug significantly increases the construction time large pipeline graphs, but can be resolved with bit of pre-computation and plumbing of which transforms are using which PCollections.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)