You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/04 18:48:14 UTC

[GitHub] [airflow] mik-laj commented on a change in pull request #12558: Add connection form support to provider discovery

mik-laj commented on a change in pull request #12558:
URL: https://github.com/apache/airflow/pull/12558#discussion_r536305880



##########
File path: dev/provider_packages/refactor_provider_packages.py
##########
@@ -730,6 +730,9 @@ def kubernetes_package_filter(node: LN, capture: Capture, filename: Filename) ->
             .rename("add_sidecar")
         )
 
+    def refactor_www(self):
+        (self.qry.select_module("airflow.www").rename("airflow.www_rbac"))

Review comment:
       I wonder if we shouldn't have moved this module back before the Airflow 2.0 release. This is a breaking change and has very little benefit.  Moving everything from airflow.www_rbac to airflow.www makes it difficult to write universal plugins.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org