You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@brooklyn.apache.org by sv...@apache.org on 2017/02/03 16:55:08 UTC
[3/3] brooklyn-server git commit: Closes #545
Closes #545
Delete EntityFactory
One should instead always use `EntitySpec`, e.g. with `DynamicCluster` memberSpec config.
This PR also:
* refactors tests so that they use memberSpec instead of entityFactory.
* adds BlockingEntity.STARTUP_DELAY/SHUTDOWN_DELAY
Note that some of the code I'm deleting we didn't properly deprecate, but I'm ok with that because it was sort-of deprecated, if indirectly! For example, `DynamicFabric.FACTORY` config key was not deprecated but the type of the config key (`EntityFactory`) has been deprecated since 0.7.0. Similarly, the classes `AbstractConfigurableEntityFactory` and `ClosureEntityFactory` were not deprecated but the interface `EntityFactory` was deprecated so it's clear enough that these classes should not have been used (even if direct use of them would not have given a nice deprecation warning).
Project: http://git-wip-us.apache.org/repos/asf/brooklyn-server/repo
Commit: http://git-wip-us.apache.org/repos/asf/brooklyn-server/commit/5ce7ba69
Tree: http://git-wip-us.apache.org/repos/asf/brooklyn-server/tree/5ce7ba69
Diff: http://git-wip-us.apache.org/repos/asf/brooklyn-server/diff/5ce7ba69
Branch: refs/heads/master
Commit: 5ce7ba69a7a1f59d31004c2e15443c2420eb73d5
Parents: 0745ab3 0bf373a
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Authored: Fri Feb 3 18:54:50 2017 +0200
Committer: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Committed: Fri Feb 3 18:54:50 2017 +0200
----------------------------------------------------------------------
.../AbstractConfigurableEntityFactory.java | 88 -----
.../factory/BasicConfigurableEntityFactory.java | 77 -----
.../entity/factory/ClosureEntityFactory.java | 54 ----
.../factory/ConfigurableEntityFactory.java | 33 --
...figurableEntityFactoryFromEntityFactory.java | 45 ---
.../core/entity/factory/EntityFactory.java | 32 --
.../factory/EntityFactoryForLocation.java | 30 --
.../brooklyn/entity/group/DynamicCluster.java | 12 -
.../entity/group/DynamicClusterImpl.java | 42 +--
.../brooklyn/entity/group/DynamicFabric.java | 7 -
.../entity/group/DynamicFabricImpl.java | 26 +-
.../brooklyn/util/core/flags/TypeCoercions.java | 23 --
.../core/test/entity/BlockingEntity.java | 5 +
.../core/test/entity/BlockingEntityImpl.java | 3 +
.../entity/group/DynamicClusterTest.java | 324 +++++++------------
.../entity/group/DynamicFabricTest.java | 253 ++++-----------
16 files changed, 207 insertions(+), 847 deletions(-)
----------------------------------------------------------------------