You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2022/11/25 00:05:32 UTC
[GitHub] [servicecomb-java-chassis] anantdahiya8 opened a new pull request, #3501: [SCB-2731] fix flaky junit tests in common and core
anantdahiya8 opened a new pull request, #3501:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3501
###Summary
1. `TestInvocation#traceIdGeneratorInit`
- `Json.encode` can return the json string in different order. We need to check for all the possible values so that the test does not fail for some cases.
2. `TestRestClientRequestImpl#testForm`
- Checking all possible values so that the test does not fail
3. `TestRestClientRequestImpl#testCookie`
- Mocking for both cases `"region=china-north; sessionid=abcdefghijklmnopqrstuvwxyz; "` and `"sessionid=abcdefghijklmnopqrstuvwxyz; region=china-north; "`, So that the mock function works for both the cases
4. `RestServerCodecFilterTest#should_convert_exception_to_response_when_decode_request_failed`
- `Json.encode` can return the json string in different order. We need to check for all the possible values so that the test does not fail for some cases.
5. `RestProducerInvocationCreatorTest#should_failed_when_not_defined_any_schema`
- `Json.encode` can return the json string in different order. We need to check for all the possible values so that the test does not fail for some cases.
6. `RestProducerInvocationCreatorTest#should_failed_when_accept_is_not_support`
- `Json.encode` can return the json string in different order. We need to check for all the possible values so that the test does not fail for some cases.
Bug Link : https://issues.apache.org/jira/projects/SCB/issues/SCB-2731
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] codecov-commenter commented on pull request #3501: [SCB-2731] fix flaky junit tests in common and core
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3501:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3501#issuecomment-1326910703
# [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3501?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3501](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3501?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fe65835) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/8a7f6b241cb86fb6fa61f43c72379b3021b601c8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8a7f6b2) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #3501 +/- ##
=========================================
Coverage 74.38% 74.39%
Complexity 670 670
=========================================
Files 1589 1589
Lines 39830 39830
Branches 3633 3633
=========================================
+ Hits 29628 29631 +3
+ Misses 8721 8718 -3
Partials 1481 1481
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3501?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...mb/metrics/core/meter/os/cpu/AbstractCpuUsage.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3501/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0cmljcy9tZXRyaWNzLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL21ldHJpY3MvY29yZS9tZXRlci9vcy9jcHUvQWJzdHJhY3RDcHVVc2FnZS5qYXZh) | `88.88% <0.00%> (-11.12%)` | :arrow_down: |
| [...egistry/client/http/ServiceRegistryClientImpl.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3501/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2NsaWVudC9odHRwL1NlcnZpY2VSZWdpc3RyeUNsaWVudEltcGwuamF2YQ==) | `68.45% <0.00%> (+0.38%)` | :arrow_up: |
| [...mb/config/ConfigCenterConfigurationSourceImpl.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3501/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHluYW1pYy1jb25maWcvY29uZmlnLWNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9jb25maWcvQ29uZmlnQ2VudGVyQ29uZmlndXJhdGlvblNvdXJjZUltcGwuamF2YQ==) | `10.63% <0.00%> (+1.06%)` | :arrow_up: |
| [.../servicecomb/registry/discovery/DiscoveryTree.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3501/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1yZWdpc3RyeS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvcmVnaXN0cnkvZGlzY292ZXJ5L0Rpc2NvdmVyeVRyZWUuamF2YQ==) | `100.00% <0.00%> (+3.27%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #3501: [SCB-2731] fix flaky junit tests in common and core
Posted by GitBox <gi...@apache.org>.
liubao68 merged PR #3501:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3501
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org