[GitHub] [incubator-superset] graceguo-supercat edited a comment on issue #7449: Only allow GET method for explore_json by feature flag

[GitBox <gi...@apache.org>]

graceguo-supercat edited a comment on issue #7449: Only allow GET method for explore_json by feature flag
URL: https://github.com/apache/incubator-superset/pull/7449#issuecomment-491437523
 
 
   thanks for the comment. But i am not sure how to make unittest pass.
   I want to mock `is_feature_enabled` method and test both True or False conditions:
   
   > @mock.patch('superset.views.core.is_feature_enabled')
   
   but it seems `if not is_feature_enabled('ENABLE_EXPLORE_JSON_CSRF_PROTECTION')` line
   never pickup my mock value....do you have some trick? thank you @DiggidyDave !!
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org