[jira] Updated: (SOLR-689) rename multicore.xml solr.xml

["Hoss Man (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SOLR-689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hoss Man updated SOLR-689:
--------------------------

    Attachment: SOLR-689.patch

Patch represents the *minimal* things needed to accomplish the following:
# example "Multi Core" config is renamed solr.xml
# example solr.xml has root tag of <solr> containing <multicore>
# MultiCore.java accepts root tag of <solr>, but does not require it .. only cares that <multicore> exists somewhere
# MultiCore.java config persistence writes info out to solr.xml and includes <solr> root tag
# references to multicore.xml in CHANGES.txt changed to solr.xml
# all tests pass

Things not attempted in this patch:
# renaming or refactoring existing methods or classes
# renaming config files used by tests from multicore*.xml to solr*.xml
# adding root <solr> tag to config files used by tests

(those things can still be done, but are less crucial in my opinion)

Comments?  Objections to this being committed?



> rename multicore.xml solr.xml
> -----------------------------
>
>                 Key: SOLR-689
>                 URL: https://issues.apache.org/jira/browse/SOLR-689
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Hoss Man
>             Fix For: 1.3
>
>         Attachments: SOLR-689.patch
>
>
> Per mailing list discussion (see link below) it seems prudent to rename multicore.xml to solr.xml prior to the 1.3 release.
> short summary of the main motivations for doing this...
> {verbatim}
>    1) The name of the file corresponds with one specific way it can be
>       used, but may not be applicable to all usages (namely: you can
>       have a multicore.xml file but only use one core)
>    2) The "first" config file checked to determine the application's
>       behavior, and what paths will be checked for other config files
>       is named after one specific feature of the application. 
> {verbatim}
> General consensus of the thread so far seems to be that this is a good idea, and gives us more options for the future.
> http://www.nabble.com/Rename-multicore.xml---to18877268.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.