You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/07/03 08:14:27 UTC
[GitHub] [pinot] npawar commented on pull request #8978: #8970 Minion tab in Pinot UI

npawar commented on PR #8978:
URL: https://github.com/apache/pinot/pull/8978#issuecomment-1173035468

   Thanks @satishwaghela ! Just played around with this and it's pretty neat! Here's some suggestions:
   
   1. On Homepage, Move MINIONS after SERVERS (Order of these tables should be Controllers, Brokers, Servers, Minions)
   <img width="1393" alt="Screen Shot 2022-07-03 at 12 15 41 AM" src="https://user-images.githubusercontent.com/19693933/177031166-ddd5d2b1-07c6-4aeb-9eff-92aa05a28bff.png">
   
   2. Is this validation coming from UI or backend? If UI, no need for this restriction in tags for Minions, it can be anything.
   <img width="1197" alt="Screen Shot 2022-07-03 at 12 18 12 AM" src="https://user-images.githubusercontent.com/19693933/177031175-c646ed07-fc6a-41e0-bfd1-34393ce2b657.png">
   
   3. After editing the tag for Minion, I see this table appear below, which should not be there
   <img width="1185" alt="Screen Shot 2022-07-03 at 12 18 31 AM" src="https://user-images.githubusercontent.com/19693933/177031190-548fba7b-a2b4-4735-8992-dbf821cf4edb.png">
   
   4. Replace Execution Time with “Elapsed Time”. Calculate the value using System.currentTimeMillis() - startTime. Show value in minutes if < 60. In hours + minutes if > 60
   <img width="1601" alt="Screen Shot 2022-07-03 at 12 27 12 AM" src="https://user-images.githubusercontent.com/19693933/177031204-c850df92-e705-41ba-b1e6-419b38d6f9cc.png">
   
   5. After clicking Schedule Now, show a modal with message “Are you sure you want to schedule this task?” If user clicks YES, then show the Task ID from the response as “<Task id> scheduled” and give user an option to dismiss the message
   <img width="1086" alt="Screen Shot 2022-07-03 at 1 02 11 AM" src="https://user-images.githubusercontent.com/19693933/177031134-64665da6-1f5c-4d75-a3c9-752528420fe4.png">
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org