You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "Sylvie-Wxr (via GitHub)" <gi...@apache.org> on 2024/05/19 05:33:44 UTC
[PR] [GsoC][BanyanDB] Self-Observability: Create Internal Group [skywalking-banyandb]
Sylvie-Wxr opened a new pull request, #446:
URL: https://github.com/apache/skywalking-banyandb/pull/446
### <Feature description>
- [x] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
- [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Fixes apache/skywalking#10634.
- [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking-banyandb/blob/main/CHANGES.md).
### GSOC proposal link:
https://docs.google.com/document/d/1bX-JCeSocBNRnb8YMOThIiz8IeYmsLADaULhAp0ILWo/
### Import cycle problem:
Most of code changes are made to resolve the package import cycle problem when we import `metadata` in `observability`.
**Problem statement**: embeddedetcd -> observability -> metadata -> schema -> embeddedetcd
Changes made to resolve import cycle:
1. create new package `embeddedserver` and `schema_test`
2. export: `flagEtcdEndpointsName`, `equalityChecker`, `checkerMap`, `Metadata.Key()`,
3. export these `etcdSchemaRegistry` methods and add them to `Registry` interface: get, register, newWatcher
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [GsoC][BanyanDB] Self-Observability: Create Internal Group [skywalking-banyandb]
Posted by "hanahmily (via GitHub)" <gi...@apache.org>.
hanahmily merged PR #446:
URL: https://github.com/apache/skywalking-banyandb/pull/446
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [GsoC][BanyanDB] Self-Observability: Create Internal Group [skywalking-banyandb]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #446:
URL: https://github.com/apache/skywalking-banyandb/pull/446#issuecomment-2119154649
## [Codecov](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/446?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `63.15789%` with `7 lines` in your changes are missing coverage. Please review.
> Project coverage is 51.84%. Comparing base [(`c827067`)](https://app.codecov.io/gh/apache/skywalking-banyandb/commit/c8270670d47a9c6caa2661af434157656c4b7eaf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`0d72fd8`)](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/446?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
| [Files](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/446?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [banyand/metadata/schema/index.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/446?src=pr&el=tree&filepath=banyand%2Fmetadata%2Fschema%2Findex.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YmFueWFuZC9tZXRhZGF0YS9zY2hlbWEvaW5kZXguZ28=) | 0.00% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/446?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [banyand/metadata/schema/etcd.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/446?src=pr&el=tree&filepath=banyand%2Fmetadata%2Fschema%2Fetcd.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YmFueWFuZC9tZXRhZGF0YS9zY2hlbWEvZXRjZC5nbw==) | 87.50% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/446?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [banyand/metadata/schema/node.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/446?src=pr&el=tree&filepath=banyand%2Fmetadata%2Fschema%2Fnode.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YmFueWFuZC9tZXRhZGF0YS9zY2hlbWEvbm9kZS5nbw==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/446?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [banyand/metadata/schema/property.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/446?src=pr&el=tree&filepath=banyand%2Fmetadata%2Fschema%2Fproperty.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YmFueWFuZC9tZXRhZGF0YS9zY2hlbWEvcHJvcGVydHkuZ28=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/446?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [banyand/metadata/schema/stream.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/446?src=pr&el=tree&filepath=banyand%2Fmetadata%2Fschema%2Fstream.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YmFueWFuZC9tZXRhZGF0YS9zY2hlbWEvc3RyZWFtLmdv) | 0.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/446?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [banyand/metadata/schema/topn.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/446?src=pr&el=tree&filepath=banyand%2Fmetadata%2Fschema%2Ftopn.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YmFueWFuZC9tZXRhZGF0YS9zY2hlbWEvdG9wbi5nbw==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/446?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #446 +/- ##
===========================================
+ Coverage 40.87% 51.84% +10.97%
===========================================
Files 157 156 -1
Lines 18734 18687 -47
===========================================
+ Hits 7658 9689 +2031
+ Misses 10445 8199 -2246
- Partials 631 799 +168
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/446?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org