You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/07/07 11:28:00 UTC
[GitHub] [rocketmq] tsunghanjacktsai opened a new pull request, #4572: Modify Dependency Exclusions for DLedger 0.2.7
tsunghanjacktsai opened a new pull request, #4572:
URL: https://github.com/apache/rocketmq/pull/4572
**Make sure set the target branch to `develop`**
## What is the purpose of the change
Adapt the log4j2 in DLedger 0.2.7, which needs to be excluded while being in RocketMQ.
## Brief changelog
1. Remove slf4j-log4j12 exclusion in store/pom.xml.
2. Add exclusions for the log4j2 dependencies within DLedger 0.2.7.
## Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] duhenglucky merged pull request #4572: Modify Dependency Exclusions for DLedger 0.2.7
Posted by GitBox <gi...@apache.org>.
duhenglucky merged PR #4572:
URL: https://github.com/apache/rocketmq/pull/4572
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #4572: Modify Dependency Exclusions for DLedger 0.2.7
Posted by GitBox <gi...@apache.org>.
coveralls commented on PR #4572:
URL: https://github.com/apache/rocketmq/pull/4572#issuecomment-1177676909
[](https://coveralls.io/builds/50675037)
Coverage increased (+0.2%) to 52.19% when pulling **2ac0ba29d83d635ec2e3483b9334cddd1f9d03b6 on tsunghanjacktsai:log4j_exclusion_for_dledger_0.2.7** into **418a5b2eaf746735d9b9c8b7b3759ec3aa096f31 on apache:develop**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org