You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Paul Burba <pt...@gmail.com> on 2008/03/19 18:42:08 UTC
Re: svn commit: r29578 - trunk/subversion/mod_dav_svn/reports
On Sun, Feb 24, 2008 at 8:07 AM, <di...@tigris.org> wrote:
> Author: dionisos
> Date: Sun Feb 24 04:07:22 2008
> New Revision: 29578
>
> Log:
> Destroy a pool after use.
>
> * subversion/mod_dav_svn/reports/log.c
> (log_receiver): When creating a pool, destroy it after use.
>
>
> Modified:
> trunk/subversion/mod_dav_svn/reports/log.c
>
> Modified: trunk/subversion/mod_dav_svn/reports/log.c
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/mod_dav_svn/reports/log.c?pathrev=29578&r1=29577&r2=29578
> ==============================================================================
> --- trunk/subversion/mod_dav_svn/reports/log.c (original)
> +++ trunk/subversion/mod_dav_svn/reports/log.c Sun Feb 24 04:07:22 2008
> @@ -237,6 +237,8 @@
> }
> }
>
> + svn_pool_destroy(iterpool);
> +
> SVN_ERR(dav_svn__send_xml(lrb->bb, lrb->output, "</S:log-item>" DEBUG_CR));
Hi Erik,
The test suite on Windows fails over ra_neon since this change. A
simple reproduction: Checkout an empty repository, add a directory,
then do a URL->WC copy of the directory:
>set url=http://localhost/svn-test-work/repositories/REPOS
>svnadmin create ..\repositories\REPOS
>svn co %url% WC
Checked out revision 0.
>mkdir WC\dir
>svn add wc\dir
A WC\dir
>svn ci WC -m ""
Adding WC\dir
Committed revision 1.
>svn copy %url%/dir WC\dir_copy
Checked out revision 1.
A WC\dir_copy
..\..\..\subversion\libsvn_ra_neon\util.c:601: (apr_err=175002)
svn: REPORT of '/svn-test-work/repositories/REPOS/!svn/bc/0': Could
not read status line: An existing connection was forcibly closed by
the remote host.
(http://localhost)
It's not just this change though, it has been back-ported to 1.5.x and
that is working fine for me. Trying to figure out what is wrong, but
if you have any thoughts they'd be appreciated.
Paul
P.S. Can anyone with a Win32 box replicate this problem?
> return SVN_NO_ERROR;
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: svn-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: svn-help@subversion.tigris.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r29578 - trunk/subversion/mod_dav_svn/reports
Posted by Paul Burba <pt...@gmail.com>.
On Wed, Mar 19, 2008 at 2:42 PM, Paul Burba <pt...@gmail.com> wrote:
> On Sun, Feb 24, 2008 at 8:07 AM, <di...@tigris.org> wrote:
> > Author: dionisos
> > Date: Sun Feb 24 04:07:22 2008
> > New Revision: 29578
> >
> > Log:
> > Destroy a pool after use.
> >
> > * subversion/mod_dav_svn/reports/log.c
> > (log_receiver): When creating a pool, destroy it after use.
> >
> >
> > Modified:
> > trunk/subversion/mod_dav_svn/reports/log.c
> >
> > Modified: trunk/subversion/mod_dav_svn/reports/log.c
> > URL: http://svn.collab.net/viewvc/svn/trunk/subversion/mod_dav_svn/reports/log.c?pathrev=29578&r1=29577&r2=29578
> > ==============================================================================
> > --- trunk/subversion/mod_dav_svn/reports/log.c (original)
> > +++ trunk/subversion/mod_dav_svn/reports/log.c Sun Feb 24 04:07:22 2008
> > @@ -237,6 +237,8 @@
> > }
> > }
> >
> > + svn_pool_destroy(iterpool);
> > +
> > SVN_ERR(dav_svn__send_xml(lrb->bb, lrb->output, "</S:log-item>" DEBUG_CR));
>
> Hi Erik,
>
> The test suite on Windows fails over ra_neon since this change. A
> simple reproduction: Checkout an empty repository, add a directory,
> then do a URL->WC copy of the directory:
>
> >set url=http://localhost/svn-test-work/repositories/REPOS
>
> >svnadmin create ..\repositories\REPOS
>
> >svn co %url% WC
> Checked out revision 0.
>
> >mkdir WC\dir
>
> >svn add wc\dir
> A WC\dir
>
> >svn ci WC -m ""
> Adding WC\dir
>
> Committed revision 1.
>
> >svn copy %url%/dir WC\dir_copy
> Checked out revision 1.
> A WC\dir_copy
> ..\..\..\subversion\libsvn_ra_neon\util.c:601: (apr_err=175002)
> svn: REPORT of '/svn-test-work/repositories/REPOS/!svn/bc/0': Could
> not read status line: An existing connection was forcibly closed by
> the remote host.
> (http://localhost)
Oh just shoot me please. After doing a full rebuild everything is
working fine. Sorry for the noise.
Paul
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org