[GitHub] [beam] ibzib commented on a change in pull request #12461: [BEAM-10633] UdfImpl hits NPE when returns a List

[GitBox <gi...@apache.org>]

ibzib commented on a change in pull request #12461:
URL: https://github.com/apache/beam/pull/12461#discussion_r465400167



##########
File path: sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/BeamSqlDslUdfUdafTest.java
##########
@@ -101,6 +104,21 @@ public void testJodaTimeUdfUdaf() throws Exception {
     pipeline.run().waitUntilFinish();
   }
 
+  @Test
+  public void testListUdf() throws Exception {

Review comment:
       We should separate this into two modular test cases, one with a UDF that takes an array as an argument (e.g. the length function), and one with a UDF that returns an array (e.g. array constructor, like your previous test).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org