[GitHub] [accumulo] milleruntime commented on a change in pull request #1531: Bump ZooKeeper dependency to 3.5.7

[GitBox <gi...@apache.org>]

milleruntime commented on a change in pull request #1531: Bump ZooKeeper dependency to 3.5.7
URL: https://github.com/apache/accumulo/pull/1531#discussion_r384757398
 
 

 ##########
 File path: test/src/test/java/org/apache/accumulo/test/fate/zookeeper/ZooLockTest.java
 ##########
 @@ -274,42 +274,43 @@ public void testUnexpectedEvent() throws Exception {
     String parent = "/zltest-" + this.hashCode() + "-l" + pdCount.incrementAndGet();
 
     ConnectedWatcher watcher = new ConnectedWatcher();
-    ZooKeeper zk = new ZooKeeper(accumulo.getZooKeepers(), 30000, watcher);
-    zk.addAuthInfo("digest", "accumulo:secret".getBytes(UTF_8));
+    try (ZooKeeper zk = new ZooKeeper(accumulo.getZooKeepers(), 30000, watcher)) {
 
 Review comment:
   Would be good to make more use of this being autoclosable but that could be a follow on ticket.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services