You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/09/17 19:29:28 UTC
[GitHub] [netbeans] sdedic opened a new pull request #3175: Avoid ClassLoader resource lookups
sdedic opened a new pull request #3175:
URL: https://github.com/apache/netbeans/pull/3175
I've missed yet another resource lookup through ClassLoader. In the case of `NbClassNodeResolver`, alll resources were loaded by the parent (= `ClassLoaderSupport` created by `ClassPath`) of the GroovyclassLoader (= `ParsingClassLoader`) so the resource lookup through ClassPath's classloader is completely unnecessary. in addition, loadByClassLoading was set to false, so I've deleted the relevant part of the code.
i also completely disabled error failures in compilation phases; Groovy tends to bail out on trivial errors (like imported symbol not exists) and will skip later more interesting compilation phases which attribute the tree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #3175: Avoid ClassLoader resource lookups
Posted by GitBox <gi...@apache.org>.
sdedic commented on pull request #3175:
URL: https://github.com/apache/netbeans/pull/3175#issuecomment-923750825
Just unrelated `SdkSuiteTest` has failed; merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic merged pull request #3175: Avoid ClassLoader resource lookups
Posted by GitBox <gi...@apache.org>.
sdedic merged pull request #3175:
URL: https://github.com/apache/netbeans/pull/3175
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists