You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/01/21 09:33:29 UTC

[GitHub] [incubator-nuttx] Ouss4 opened a new pull request #2731: xtensa/esp_allocateheap.c: Correct ROM memory boundaries in SMP case

Ouss4 opened a new pull request #2731:
URL: https://github.com/apache/incubator-nuttx/pull/2731


   ## Summary
   SMP was broken because the ROM memory wasn't set correctly.  Some
   regions were shared with the ROM code which resulted in corrupted data.
   
   ## Impact
   Fix ESP32 SMP.
   ## Testing
   esp32-devkitc:smp was asserting on boot.  Now it works again.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #2731: xtensa/esp_allocateheap.c: Correct ROM memory boundaries in SMP case

Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #2731:
URL: https://github.com/apache/incubator-nuttx/pull/2731#issuecomment-774918344


   @yamt You can check here: https://github.com/espressif/esp-idf/blob/master/components/soc/esp32/soc_memory_layout.c#L147-L168
   
   However, the values where adapted a little after inspecting the objdump of the ROM binaries.  I'll see if those are available somewhere for public consumption. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] yamt commented on pull request #2731: xtensa/esp_allocateheap.c: Correct ROM memory boundaries in SMP case

Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #2731:
URL: https://github.com/apache/incubator-nuttx/pull/2731#issuecomment-774859795


   @Ouss4 is there any documentation about these magic addresses? even a pointer to esp-idf code can be useful.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis merged pull request #2731: xtensa/esp_allocateheap.c: Correct ROM memory boundaries in SMP case

Posted by GitBox <gi...@apache.org>.
acassis merged pull request #2731:
URL: https://github.com/apache/incubator-nuttx/pull/2731


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis merged pull request #2731: xtensa/esp_allocateheap.c: Correct ROM memory boundaries in SMP case

Posted by GitBox <gi...@apache.org>.
acassis merged pull request #2731:
URL: https://github.com/apache/incubator-nuttx/pull/2731


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org