You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by actuaryzhang <gi...@git.apache.org> on 2017/05/26 00:13:14 UTC

[GitHub] spark pull request #18116: [SPARK-20892][SparkR] Add SQL trunc function to S...

Github user actuaryzhang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18116#discussion_r118612551
  
    --- Diff: R/pkg/inst/tests/testthat/test_sparkSQL.R ---
    @@ -1404,6 +1404,8 @@ test_that("column functions", {
       c20 <- to_timestamp(c) + to_timestamp(c, "yyyy") + to_date(c, "yyyy")
       c21 <- posexplode_outer(c) + explode_outer(c)
       c22 <- not(c)
    +  c23 <- trunc(c) + trunc(c, "year") + trunc(c, "yyyy") + trunc(c, "yy") +
    --- End diff --
    
    Not sure what this does. Is this the current test for these SQL functions? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org