[GitHub] [iceberg] bryanck commented on a diff in pull request #8270: Core: Re-apply Hadoop conf if it's null after Kryo ser/de in ResolvingFileIO

["bryanck (via GitHub)" <gi...@apache.org>]

bryanck commented on code in PR #8270:
URL: https://github.com/apache/iceberg/pull/8270#discussion_r1288719846


##########
core/src/main/java/org/apache/iceberg/io/ResolvingFileIO.java:
##########
@@ -133,6 +134,10 @@ private FileIO io(String location) {
     String impl = implFromLocation(location);
     FileIO io = ioInstances.get(impl);
     if (io != null) {
+      // re-apply the config in case it's null after Kryo serialization
+      if (io instanceof HadoopFileIO && ((HadoopFileIO) io).conf() == null) {

Review Comment:
   Does it make sense to change `HadoopFileIO` to `HadoopConfigurable`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org