You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "mridulm (via GitHub)" <gi...@apache.org> on 2023/10/03 04:07:37 UTC

Re: [PR] [SPARK-45283][CORE][TESTS] Make StatusTrackerSuite less fragile [spark]

mridulm commented on code in PR #43194:
URL: https://github.com/apache/spark/pull/43194#discussion_r1343460096


##########
core/src/test/scala/org/apache/spark/StatusTrackerSuite.scala:
##########
@@ -140,6 +140,14 @@ class StatusTrackerSuite extends SparkFunSuite with Matchers with LocalSparkCont
     }
 
     sc.removeJobTag("tag1")
+    eventually(timeout(60.seconds)) {
+      // Make sure that only two jobs are tagged after tag1
+      firstJobFuture.isCompleted should be(true)
+      secondJobFuture.isCompleted should be(true)
+      sc.getJobTags should be (Set("tag2"))
+      sc.statusTracker.getJobIdsForTag("tag1").toSet.size should be(2)
+    }
+

Review Comment:
   This is not going to fix the issue - I have detailed the fix required for address the flakiness.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org