You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@parquet.apache.org by "Gabor Szadovszky (Jira)" <ji...@apache.org> on 2019/10/24 12:27:00 UTC

[jira] [Assigned] (PARQUET-1683) Remove unnecessary string converting in readFooter method

     [ https://issues.apache.org/jira/browse/PARQUET-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gabor Szadovszky reassigned PARQUET-1683:
-----------------------------------------

    Assignee: Xinli Shang

> Remove unnecessary string converting in readFooter method
> ---------------------------------------------------------
>
>                 Key: PARQUET-1683
>                 URL: https://issues.apache.org/jira/browse/PARQUET-1683
>             Project: Parquet
>          Issue Type: Improvement
>          Components: parquet-mr
>    Affects Versions: 1.11.0
>            Reporter: Xinli Shang
>            Assignee: Xinli Shang
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.11.0
>
>
> The method (String filePath = file.toString()) is always called even filePath is not used(it is only used when an exception is thrown which is rare).  This kind of string conversion should be avoided when it is not used in terms of memory & CPU efficiency. 
>  
> [https://github.com/apache/parquet-mr/pull/695]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)