[GitHub] [incubator-superset] khtruong commented on a change in pull request #7391: feat: see Presto row and array data types

[GitBox <gi...@apache.org>]

khtruong commented on a change in pull request #7391: feat: see Presto row and array data types
URL: https://github.com/apache/incubator-superset/pull/7391#discussion_r279119011
 
 

 ##########
 File path: superset/db_engine_specs.py
 ##########
 @@ -814,6 +834,164 @@ def get_view_names(cls, inspector, schema):
         """
         return []
 
+    @classmethod
+    def _create_column_info(cls, column, name, data_type):
 
 Review comment:
   Definitely!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org