You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ChrisSamo632 (via GitHub)" <gi...@apache.org> on 2023/06/26 21:25:55 UTC
[GitHub] [nifi] ChrisSamo632 opened a new pull request, #7441: NIFI-11480 add option to group PutElasticsearchRecord errors by Elast…
ChrisSamo632 opened a new pull request, #7441:
URL: https://github.com/apache/nifi/pull/7441
…icsearch _bulk error type
<!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
<!-- contributor license agreements. See the NOTICE file distributed with -->
<!-- this work for additional information regarding copyright ownership. -->
<!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
<!-- (the "License"); you may not use this file except in compliance with -->
<!-- the License. You may obtain a copy of the License at -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
<!-- See the License for the specific language governing permissions and -->
<!-- limitations under the License. -->
# Summary
[NIFI-00000](https://issues.apache.org/jira/browse/NIFI-00000)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [ ] Pull Request based on current revision of the `main` branch
- [ ] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [ ] Build completed using `mvn clean install -P contrib-check`
- [ ] JDK 17
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 commented on pull request #7441: NIFI-11480 add option to group PutElasticsearchRecord errors by Elasticsearch _bulk error type
Posted by "mattyb149 (via GitHub)" <gi...@apache.org>.
mattyb149 commented on PR #7441:
URL: https://github.com/apache/nifi/pull/7441#issuecomment-1681282236
How do you test different errors in a NiFi instance (not a unit test)? Given the Operation I can only generate one kind of error at a time. This looks good though, just want to verify I can get groups of errors then I'll merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 commented on pull request #7441: NIFI-11480 add option to group PutElasticsearchRecord errors by Elasticsearch _bulk error type
Posted by "mattyb149 (via GitHub)" <gi...@apache.org>.
mattyb149 commented on PR #7441:
URL: https://github.com/apache/nifi/pull/7441#issuecomment-1690558877
+1 LGTM, thanks for the improvement and the reproduction flow! Merging to support/nifi-1.x and main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 closed pull request #7441: NIFI-11480 add option to group PutElasticsearchRecord errors by Elasticsearch _bulk error type
Posted by "mattyb149 (via GitHub)" <gi...@apache.org>.
mattyb149 closed pull request #7441: NIFI-11480 add option to group PutElasticsearchRecord errors by Elasticsearch _bulk error type
URL: https://github.com/apache/nifi/pull/7441
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] ChrisSamo632 commented on pull request #7441: NIFI-11480 add option to group PutElasticsearchRecord errors by Elasticsearch _bulk error type
Posted by "ChrisSamo632 (via GitHub)" <gi...@apache.org>.
ChrisSamo632 commented on PR #7441:
URL: https://github.com/apache/nifi/pull/7441#issuecomment-1683405494
> How do you test different errors in a NiFi instance (not a unit test)? Given the Operation I can only generate one kind of error at a time. This looks good though, just want to verify I can get groups of errors then I'll merge
@mattyb149 my suggestion (although I'll not be in a position to try it for a while), would be to create an index with a numeric field mapping, index a document with a known id, then run the processor in update mode with 2 records - 1 with a mismatched id (should result in a not_found error), the 2nd with the correct id but a non-numeric value for the numeric field (should give a "format exception")
From memory, this is the kind of thing I've tried to show in the unit/integration tests
This could possibly all be done with a single FlowFile and run off the processor - the index operation can be set by the value of a field within a record. So something like:
1. Op=index, id=1, fields: foo="bar", baz=1
2. Op=update, id=unknown, fields: foo="zap"
3. Op=update, id=1, fields: baz="not a number"
Index=bulk_test, Index Op record path=/Op, id record path=/id
That's a chance Elasticsearch will set the "baz" fields mapping to string by default, but hopefully it'll choose Integer. If so, we'll need to separately define the index mappings and pre-create the index with an InvokeHTTP call (for example). If you don't get to it first, I'll try to put a Flow Definition together and attach it to the jira ticket as an example
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] ChrisSamo632 commented on pull request #7441: NIFI-11480 add option to group PutElasticsearchRecord errors by Elasticsearch _bulk error type
Posted by "ChrisSamo632 (via GitHub)" <gi...@apache.org>.
ChrisSamo632 commented on PR #7441:
URL: https://github.com/apache/nifi/pull/7441#issuecomment-1690502339
@mattyb149 I've added an example Flow Definition to the Jira ticket that exhibits this behaviour, for reference
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org