You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/08/18 12:31:12 UTC
[GitHub] [shardingsphere] sandynz opened a new issue, #20275: Refactor DistSQL drop scaling jobId to clean scaling jobId
sandynz opened a new issue, #20275:
URL: https://github.com/apache/shardingsphere/issues/20275
Current DistSQL: drop scaling j01001;
Final DistSQL: clean scaling j01001;
There're plenty of classes and files need to be modified, include grammar files and related classes, and also DistSQL handler, unit test etc.
We could find them out by searching:
1. Class name search by text: DropMigration . Rename classes, replace `Drop` to `Clean`
2. Text search by regex: drop[ _-]*scaling . Replace text `drop` to `clean` , classes generated by ANTLR4 could be ignored
Firstly, we could change ANTLR4 grammer file, replace `drop` to `clean`:
- migration/RALStatement.g4
- MigrationDistSQLStatement.g4
Then run `mvn clean install -Dmaven.javadoc.skip=true -Djacoco.skip=true -Dspotless.apply.skip=true` in `shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-distsql` module.
And then continue to rename or replace by keyword searching.
After go through these changed files, we could basically know how to add or modify scaling DistSQL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz closed issue #20275: Refactor DistSQL drop scaling jobId to clean scaling jobId
Posted by GitBox <gi...@apache.org>.
sandynz closed issue #20275: Refactor DistSQL drop scaling jobId to clean scaling jobId
URL: https://github.com/apache/shardingsphere/issues/20275
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] huangdx0726 commented on issue #20275: Refactor DistSQL drop scaling jobId to clean scaling jobId
Posted by GitBox <gi...@apache.org>.
huangdx0726 commented on issue #20275:
URL: https://github.com/apache/shardingsphere/issues/20275#issuecomment-1220133058
get it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] huangdx0726 commented on issue #20275: Refactor DistSQL drop scaling jobId to clean scaling jobId
Posted by GitBox <gi...@apache.org>.
huangdx0726 commented on issue #20275:
URL: https://github.com/apache/shardingsphere/issues/20275#issuecomment-1219663623
@sandynz Hi, i find some errors in `ShardingScalingRuleStatementConverter` , caused by some classes in `shardingsphere-infra-common` are userd， but no related dependencies was found in the `pom.xml` file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] huangdx0726 commented on issue #20275: Refactor DistSQL drop scaling jobId to clean scaling jobId
Posted by GitBox <gi...@apache.org>.
huangdx0726 commented on issue #20275:
URL: https://github.com/apache/shardingsphere/issues/20275#issuecomment-1219611813
also include docs？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz commented on issue #20275: Refactor DistSQL drop scaling jobId to clean scaling jobId
Posted by GitBox <gi...@apache.org>.
sandynz commented on issue #20275:
URL: https://github.com/apache/shardingsphere/issues/20275#issuecomment-1220111396
> @sandynz Hi, i find some errors in `ShardingScalingRuleStatementConverter` , caused by some classes in `shardingsphere-infra-common` are userd， but no related dependencies was found in the `pom.xml` file
Some classes depended by ShardingScalingRuleStatementConverter were changed recently, maybe you need to run `mvn clean install -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Drat.skip=true -Djacoco.skip=true -DskipITs -DskipTests -Prelease -Dspotless.apply.skip=true` again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz commented on issue #20275: Refactor DistSQL drop scaling jobId to clean scaling jobId
Posted by GitBox <gi...@apache.org>.
sandynz commented on issue #20275:
URL: https://github.com/apache/shardingsphere/issues/20275#issuecomment-1219446737
Thanks. Just assigned it to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz commented on issue #20275: Refactor DistSQL drop scaling jobId to clean scaling jobId
Posted by GitBox <gi...@apache.org>.
sandynz commented on issue #20275:
URL: https://github.com/apache/shardingsphere/issues/20275#issuecomment-1220109753
> also include docs？
Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz commented on issue #20275: Refactor DistSQL drop scaling jobId to clean scaling jobId
Posted by GitBox <gi...@apache.org>.
sandynz commented on issue #20275:
URL: https://github.com/apache/shardingsphere/issues/20275#issuecomment-1219436889
Hi @huangdx0726 , are you interesting to resolve it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] huangdx0726 commented on issue #20275: Refactor DistSQL drop scaling jobId to clean scaling jobId
Posted by GitBox <gi...@apache.org>.
huangdx0726 commented on issue #20275:
URL: https://github.com/apache/shardingsphere/issues/20275#issuecomment-1219444243
ok ， assign to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org