You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@turbine.apache.org by "Georg Kallidis (JIRA)" <ji...@apache.org> on 2012/07/18 09:56:33 UTC

[jira] [Created] (TRB-91) urlfolding configuration value never read in fulcrum DefaultParserService

Georg Kallidis created TRB-91:
---------------------------------

             Summary: urlfolding configuration value never read in fulcrum DefaultParserService 
                 Key: TRB-91
                 URL: https://issues.apache.org/jira/browse/TRB-91
             Project: Turbine
          Issue Type: Bug
          Components: Fulcrum
    Affects Versions: Core 4.0-M1
         Environment: fulcrum pool version: 1.0.4, windows 64bit, intel.
            Reporter: Georg Kallidis
            Priority: Minor


I followed the example http://wiki.apache.org/turbine/Turbine4/Turbine4.0M1/Migrate233.

I set in componentConfiguration.xml for the parser element <urlCaseFolding>lower</urlCaseFolding>, but activating DEBUG, I get always urlCaseFolding = 1, i.e. org.apache.fulcrum.parser.ParserService.URL_CASE_FOLDING_NONE.

Solution:
In org.apache.fulcrum.parser.DefaultParserService.configure(Configuration)  urlCaseFolding is only read from configuration 
if (folding == URL_CASE_FOLDING_UNSET). But folding is initialized with 
 /** The folding from the configuration */
    private int folding = URL_CASE_FOLDING_NONE;

As a consequence the configuraiton is never read (there is no setter), at least if I am not missing some hidden introspection!

At least I could get to work only if I set  private int folding to URL_CASE_FOLDING_UNSET;  (or change the condition in configure to ..NONE).


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (TRB-91) urlfolding configuration value never read in fulcrum DefaultParserService

Posted by "Thomas Vandahl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TRB-91?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Vandahl updated TRB-91:
------------------------------

    Fix Version/s: Core 4.0-M2
    
> urlfolding configuration value never read in fulcrum DefaultParserService 
> --------------------------------------------------------------------------
>
>                 Key: TRB-91
>                 URL: https://issues.apache.org/jira/browse/TRB-91
>             Project: Turbine
>          Issue Type: Bug
>          Components: Fulcrum
>    Affects Versions: Core 4.0-M1
>         Environment: fulcrum pool version: 1.0.4, windows 64bit, intel.
>            Reporter: Georg Kallidis
>            Priority: Minor
>             Fix For: Core 4.0-M2
>
>         Attachments: fulcrum-parser-update-bugfix.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> I followed the example http://wiki.apache.org/turbine/Turbine4/Turbine4.0M1/Migrate233.
> I set in componentConfiguration.xml for the parser element <urlCaseFolding>lower</urlCaseFolding>, but activating DEBUG, I get always urlCaseFolding = 1, i.e. org.apache.fulcrum.parser.ParserService.URL_CASE_FOLDING_NONE.
> Solution:
> In org.apache.fulcrum.parser.DefaultParserService.configure(Configuration)  urlCaseFolding is only read from configuration 
> if (folding == URL_CASE_FOLDING_UNSET). But folding is initialized with 
>  /** The folding from the configuration */
>     private int folding = URL_CASE_FOLDING_NONE;
> As a consequence the configuraiton is never read (there is no setter), at least if I am not missing some hidden introspection!
> At least I could get to work only if I set  private int folding to URL_CASE_FOLDING_UNSET;  (or change the condition in configure to ..NONE).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (TRB-91) urlfolding configuration value never read in fulcrum DefaultParserService

Posted by "Thomas Vandahl (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TRB-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446993#comment-13446993 ] 

Thomas Vandahl commented on TRB-91:
-----------------------------------

Thanks for the contribution. The fulcrum-parser release is the next in line.
                
> urlfolding configuration value never read in fulcrum DefaultParserService 
> --------------------------------------------------------------------------
>
>                 Key: TRB-91
>                 URL: https://issues.apache.org/jira/browse/TRB-91
>             Project: Turbine
>          Issue Type: Bug
>          Components: Fulcrum
>    Affects Versions: Core 4.0-M1
>         Environment: fulcrum pool version: 1.0.4, windows 64bit, intel.
>            Reporter: Georg Kallidis
>            Priority: Minor
>         Attachments: fulcrum-parser-update-bugfix.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> I followed the example http://wiki.apache.org/turbine/Turbine4/Turbine4.0M1/Migrate233.
> I set in componentConfiguration.xml for the parser element <urlCaseFolding>lower</urlCaseFolding>, but activating DEBUG, I get always urlCaseFolding = 1, i.e. org.apache.fulcrum.parser.ParserService.URL_CASE_FOLDING_NONE.
> Solution:
> In org.apache.fulcrum.parser.DefaultParserService.configure(Configuration)  urlCaseFolding is only read from configuration 
> if (folding == URL_CASE_FOLDING_UNSET). But folding is initialized with 
>  /** The folding from the configuration */
>     private int folding = URL_CASE_FOLDING_NONE;
> As a consequence the configuraiton is never read (there is no setter), at least if I am not missing some hidden introspection!
> At least I could get to work only if I set  private int folding to URL_CASE_FOLDING_UNSET;  (or change the condition in configure to ..NONE).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (TRB-91) urlfolding configuration value never read in fulcrum DefaultParserService

Posted by "Georg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TRB-91?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Georg updated TRB-91:
---------------------

    Attachment: fulcrum-parser-update-bugfix.patch

With this patch covering the update to newest fulcrum-parser/upload with dependencies and bugfixes 

compilation with 

java version "1.6.0_25"
Java(TM) SE Runtime Environment (build 1.6.0_25-b06)
Java HotSpot(TM) 64-Bit Server VM (build 20.0-b11, mixed mode)

was successfull for turbine-4.0-M2-SNAPSHOT.

A form with upload field was handled properly.
                
> urlfolding configuration value never read in fulcrum DefaultParserService 
> --------------------------------------------------------------------------
>
>                 Key: TRB-91
>                 URL: https://issues.apache.org/jira/browse/TRB-91
>             Project: Turbine
>          Issue Type: Bug
>          Components: Fulcrum
>    Affects Versions: Core 4.0-M1
>         Environment: fulcrum pool version: 1.0.4, windows 64bit, intel.
>            Reporter: Georg Kallidis
>            Priority: Minor
>         Attachments: fulcrum-parser-update-bugfix.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> I followed the example http://wiki.apache.org/turbine/Turbine4/Turbine4.0M1/Migrate233.
> I set in componentConfiguration.xml for the parser element <urlCaseFolding>lower</urlCaseFolding>, but activating DEBUG, I get always urlCaseFolding = 1, i.e. org.apache.fulcrum.parser.ParserService.URL_CASE_FOLDING_NONE.
> Solution:
> In org.apache.fulcrum.parser.DefaultParserService.configure(Configuration)  urlCaseFolding is only read from configuration 
> if (folding == URL_CASE_FOLDING_UNSET). But folding is initialized with 
>  /** The folding from the configuration */
>     private int folding = URL_CASE_FOLDING_NONE;
> As a consequence the configuraiton is never read (there is no setter), at least if I am not missing some hidden introspection!
> At least I could get to work only if I set  private int folding to URL_CASE_FOLDING_UNSET;  (or change the condition in configure to ..NONE).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (TRB-91) urlfolding configuration value never read in fulcrum DefaultParserService

Posted by "Thomas Vandahl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TRB-91?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Vandahl reassigned TRB-91:
---------------------------------

    Assignee: Thomas Vandahl
    
> urlfolding configuration value never read in fulcrum DefaultParserService 
> --------------------------------------------------------------------------
>
>                 Key: TRB-91
>                 URL: https://issues.apache.org/jira/browse/TRB-91
>             Project: Turbine
>          Issue Type: Bug
>          Components: Fulcrum
>    Affects Versions: Core 4.0-M1
>         Environment: fulcrum pool version: 1.0.4, windows 64bit, intel.
>            Reporter: Georg Kallidis
>            Assignee: Thomas Vandahl
>            Priority: Minor
>             Fix For: Core 4.0-M2
>
>         Attachments: fulcrum-parser-update-bugfix.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> I followed the example http://wiki.apache.org/turbine/Turbine4/Turbine4.0M1/Migrate233.
> I set in componentConfiguration.xml for the parser element <urlCaseFolding>lower</urlCaseFolding>, but activating DEBUG, I get always urlCaseFolding = 1, i.e. org.apache.fulcrum.parser.ParserService.URL_CASE_FOLDING_NONE.
> Solution:
> In org.apache.fulcrum.parser.DefaultParserService.configure(Configuration)  urlCaseFolding is only read from configuration 
> if (folding == URL_CASE_FOLDING_UNSET). But folding is initialized with 
>  /** The folding from the configuration */
>     private int folding = URL_CASE_FOLDING_NONE;
> As a consequence the configuraiton is never read (there is no setter), at least if I am not missing some hidden introspection!
> At least I could get to work only if I set  private int folding to URL_CASE_FOLDING_UNSET;  (or change the condition in configure to ..NONE).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (TRB-91) urlfolding configuration value never read in fulcrum DefaultParserService

Posted by "Georg (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TRB-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13442431#comment-13442431 ] 

Georg commented on TRB-91:
--------------------------

This issue occurred because Turbine 4.0 M1 and M2 has still fulcrum parser version 1.0.2 dependency instead of the newest 1.0.3 version, where this problem is solved (and another one too, see below). 

This should be changed: (1) the 1.0.3 from SNAPSHOT to final, (2) the pom.xml in the trunk 4.0-M2-SNAPSHOT to have the correct 1.0.3 fulcrum parser dependency.

Additionally, in the tagged version 1.0.2 the automaticUpload parameter is defined as a attribute, not as a child, which is in contrast to the documentation http://turbine.apache.org/fulcrum/fulcrum-parser/ (last change from 2009!).

(though I made the mistake to reference the fulcrum-pool instead of fulcrum-parser in the bug description)

                
> urlfolding configuration value never read in fulcrum DefaultParserService 
> --------------------------------------------------------------------------
>
>                 Key: TRB-91
>                 URL: https://issues.apache.org/jira/browse/TRB-91
>             Project: Turbine
>          Issue Type: Bug
>          Components: Fulcrum
>    Affects Versions: Core 4.0-M1
>         Environment: fulcrum pool version: 1.0.4, windows 64bit, intel.
>            Reporter: Georg Kallidis
>            Priority: Minor
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> I followed the example http://wiki.apache.org/turbine/Turbine4/Turbine4.0M1/Migrate233.
> I set in componentConfiguration.xml for the parser element <urlCaseFolding>lower</urlCaseFolding>, but activating DEBUG, I get always urlCaseFolding = 1, i.e. org.apache.fulcrum.parser.ParserService.URL_CASE_FOLDING_NONE.
> Solution:
> In org.apache.fulcrum.parser.DefaultParserService.configure(Configuration)  urlCaseFolding is only read from configuration 
> if (folding == URL_CASE_FOLDING_UNSET). But folding is initialized with 
>  /** The folding from the configuration */
>     private int folding = URL_CASE_FOLDING_NONE;
> As a consequence the configuraiton is never read (there is no setter), at least if I am not missing some hidden introspection!
> At least I could get to work only if I set  private int folding to URL_CASE_FOLDING_UNSET;  (or change the condition in configure to ..NONE).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira