You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "LuciferYang (via GitHub)" <gi...@apache.org> on 2023/12/14 03:30:39 UTC
[PR] [MINOR][CORE] Add `@tailrec` to `HadoopFSUtils#shouldFilterOutPath` [spark]
LuciferYang opened a new pull request, #44345:
URL: https://github.com/apache/spark/pull/44345
### What changes were proposed in this pull request?
This pr adds the `@scala.annotation.tailrec` annotation to the `shouldFilterOutPath` function in `HadoopFSUtils`.
### Why are the changes needed?
To improve performance.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Pass GitHub Actions
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46416][CORE] Add `@tailrec` to `HadoopFSUtils#shouldFilterOutPath` [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #44345:
URL: https://github.com/apache/spark/pull/44345#discussion_r1427560138
##########
core/src/main/scala/org/apache/spark/util/HadoopFSUtils.scala:
##########
@@ -349,6 +349,7 @@ private[spark] object HadoopFSUtils extends Logging {
private val underscoreEnd: Regex = "/_[^=/]*$".r
/** Checks if we should filter out this path. */
+ @scala.annotation.tailrec
Review Comment:
created [SPARK-46416](https://issues.apache.org/jira/browse/SPARK-46416)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46416][CORE] Add `@tailrec` to `HadoopFSUtils#shouldFilterOutPath` [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang closed pull request #44345: [SPARK-46416][CORE] Add `@tailrec` to `HadoopFSUtils#shouldFilterOutPath`
URL: https://github.com/apache/spark/pull/44345
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][CORE] Add `@tailrec` to `HadoopFSUtils#shouldFilterOutPath` [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #44345:
URL: https://github.com/apache/spark/pull/44345#discussion_r1426138762
##########
core/src/main/scala/org/apache/spark/util/HadoopFSUtils.scala:
##########
@@ -349,6 +349,7 @@ private[spark] object HadoopFSUtils extends Logging {
private val underscoreEnd: Regex = "/_[^=/]*$".r
/** Checks if we should filter out this path. */
+ @scala.annotation.tailrec
Review Comment:
cc @dongjoon-hyun
Please let me know if a Jira needs to be created, thanks ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46416][CORE] Add `@tailrec` to `HadoopFSUtils#shouldFilterOutPath` [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #44345:
URL: https://github.com/apache/spark/pull/44345#issuecomment-1857296727
Merged into master. Thanks @yaooqinn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org