You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "Aviem Zur (JIRA)" <ji...@apache.org> on 2017/03/11 15:01:04 UTC
[jira] [Updated] (BEAM-1692) Convert to Codahale Metric interfaces
where possible in WithMetricsSupport MetricRegistry
[ https://issues.apache.org/jira/browse/BEAM-1692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aviem Zur updated BEAM-1692:
----------------------------
Description:
Currently in Spark runner all Beam metrics are reported by Codahale metrics as Codahale {{Gauge}}s.
Some of the metrics are formatted to look like their counterparts in Codahale's {{GraphiteReporter}} but this is a hack and should be avoided if possible.
Instead, convert Beam metrics to their Codahale counterparts in {{WithMetricsSupport}} getters where possible.
Since Beam metrics are not 100% compatible with Codahale metrics, consider where to make tradeoffs and stay with a simple {{Gauge}}.
Also, rename {{WithMetricsSupport}} something like {{SparkBeamMetricRegistry}}
was:
Currently in Spark runner all Beam metrics are reported by Codahale metrics as Codahale {{Gauge}}s.
Some of the metrics are formatted to look like their counterparts in Codahale's {{GraphiteReporter}} but this is a hack and should be avoided if possible.
Instead, convert Beam metrics to their Codahale counterparts in {{WithMetricsSupport}} getters where possible.
Since Beam metrics are not 100% compatible with Codahale metrics, consider where to make tradeoffs and stay with a simple {{Gauge}}.
> Convert to Codahale Metric interfaces where possible in WithMetricsSupport MetricRegistry
> -----------------------------------------------------------------------------------------
>
> Key: BEAM-1692
> URL: https://issues.apache.org/jira/browse/BEAM-1692
> Project: Beam
> Issue Type: Improvement
> Components: runner-spark
> Reporter: Aviem Zur
> Assignee: Aviem Zur
> Priority: Minor
>
> Currently in Spark runner all Beam metrics are reported by Codahale metrics as Codahale {{Gauge}}s.
> Some of the metrics are formatted to look like their counterparts in Codahale's {{GraphiteReporter}} but this is a hack and should be avoided if possible.
> Instead, convert Beam metrics to their Codahale counterparts in {{WithMetricsSupport}} getters where possible.
> Since Beam metrics are not 100% compatible with Codahale metrics, consider where to make tradeoffs and stay with a simple {{Gauge}}.
> Also, rename {{WithMetricsSupport}} something like {{SparkBeamMetricRegistry}}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)