[GitHub] [drill] agozhiy edited a comment on issue #1910: DRILL-7393: Revisit Drill tests to ensure that patching is executed b…

[GitBox <gi...@apache.org>]

agozhiy edited a comment on issue #1910: DRILL-7393: Revisit Drill tests to ensure that patching is executed b…
URL: https://github.com/apache/drill/pull/1910#issuecomment-560137927
 
 
   > The meta-question is why we still need this after all these years? Shouldn't we try to normalize our usage of Guava? Also, we moved Drill's use into a shaded jar so that, presumably, it won't conflict with other usages. So, do we still need this patching hack?
   
   As I answered earlier, we need to deal with several Guava versions at once. The one used by Drill is shaded but unfortunately this is not enough.
   Also this fix do not change the approach, it just bring the tests in line with it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services