You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/02/26 15:48:51 UTC
[GitHub] GJL commented on a change in pull request #7808: [FLINK-11718][rpc]
Add onStart method to RpcEndpoint
GJL commented on a change in pull request #7808: [FLINK-11718][rpc] Add onStart method to RpcEndpoint
URL: https://github.com/apache/flink/pull/7808#discussion_r260308777
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
##########
@@ -182,6 +182,36 @@ public Dispatcher(
// Lifecycle methods
//------------------------------------------------------
+ @Override
+ public void onStart() throws Exception {
+ try {
+ super.onStart();
+ startDispatcherServices();
+ } catch (Exception e) {
+ final DispatcherException exception = new DispatcherException(String.format("Could not start the Dispatcher %s", getAddress()), e);
+ onFatalError(exception);
+ throw exception;
Review comment:
Is `throw` needed here? In production this should never run.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services