You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@spamassassin.apache.org on 2021/05/10 18:29:34 UTC
[Bug 7906] New: Meta tests that do not use networking should not be
automatically considered as a header test in _get_autolearn_points
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7906
Bug ID: 7906
Summary: Meta tests that do not use networking should not be
automatically considered as a header test in
_get_autolearn_points
Product: Spamassassin
Version: unspecified
Hardware: PC
OS: Linux
Status: NEW
Severity: normal
Priority: P2
Component: Learner
Assignee: dev@spamassassin.apache.org
Reporter: bert@bhack.net
Target Milestone: Undefined
Currently when tests are evaluated for the header and body scores for Bayes
autolearning, meta tests that define that they are not network tests (no tflags
= net) are considered both body and header tests. Of course this is obviously
not always the case in practice, since a meta test could combine only header
tests, only body tests, or a combination of both. Beyond that clearly incorrect
presumption, the code in PerMsgStatus.pm's _get_autolearn_points only considers
the maybe_body_only function if the maybe_header_only function has failed. This
means that any meta rule that does not have tflags including net, is always
considered a header test. This is absolutely false, as other code says it's
both, and all things considered it should actually depend on the rules the meta
test consists of.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7906] Meta tests that do not use networking should not be
automatically considered as a header test in _get_autolearn_points
Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7906
Bert Van de Poel <be...@bhack.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |bert@bhack.net
--- Comment #1 from Bert Van de Poel <be...@bhack.net> ---
Bug 7905 is related to this
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7905
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7906] Meta tests that do not use networking should not be automatically considered as a header test in _get_autolearn_points
Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7906
Henrik Krohns <ap...@hege.li> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|Undefined |4.0.0
Hardware|PC |All
CC| |apache@hege.li
Resolution|--- |FIXED
OS|Linux |All
Status|NEW |RESOLVED
--- Comment #2 from Henrik Krohns <ap...@hege.li> ---
Rewrote autolearn logic. Meta points are now split between head/body, according
to how many head/body rules it depends on (not recursive, just first deps are
checked). If there are no head/body deps, nothing is added. No discrimination
of network rules anymore.
Sending trunk/lib/Mail/SpamAssassin/Conf.pm
Sending trunk/lib/Mail/SpamAssassin/PerMsgStatus.pm
Transmitting file data ..done
Committing transaction...
Committed revision 1899525.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7906] Meta tests that do not use networking should not be automatically considered as a header test in _get_autolearn_points
Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7906
--- Comment #3 from Bert Van de Poel <be...@bhack.net> ---
Thanks man, this is awesome work! I really appreciate all the work you did here
and on 7904, 7905 and 7907! :D
--
You are receiving this mail because:
You are the assignee for the bug.