You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/09/12 20:33:00 UTC
[jira] [Commented] (NIFI-3369) Disable "Add" button on new
connection dialog if no relationships selected
[ https://issues.apache.org/jira/browse/NIFI-3369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16163611#comment-16163611 ]
ASF GitHub Bot commented on NIFI-3369:
--------------------------------------
GitHub user yuri1969 opened a pull request:
https://github.com/apache/nifi/pull/2152
NIFI-3369 - Disable "Add" button on new connection dialog if no relationships selected
Disabled confirmation button for both Create and Configure Connection
dialogs when no relationship was selected.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yuri1969/nifi NIFI-3369
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2152.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2152
----
commit cce5f28b3440a4a117390bf3cf5eff2fb5bc06d3
Author: yuri1969 <19...@gmail.com>
Date: 2017-09-12T17:51:10Z
NIFI-3369 - Disable "Add" button on new...
...connection dialog if no relationships selected
Disabled confirmation button for both Create and Configure Connection
dialogs when no relationship was selected.
----
> Disable "Add" button on new connection dialog if no relationships selected
> --------------------------------------------------------------------------
>
> Key: NIFI-3369
> URL: https://issues.apache.org/jira/browse/NIFI-3369
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core UI
> Affects Versions: 1.1.1
> Reporter: Andy LoPresto
> Priority: Trivial
> Labels: beginner, ui, ux, validation
> Attachments: Screen Shot 2017-01-18 at 12.14.15 PM.png
>
>
> When adding a connection, if no relationships are selected, the "Add" button should be disabled. Otherwise, a user can click "Add" and then receive an error dialog that one or more relationships must be selected.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)