You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "VuMartin (via GitHub)" <gi...@apache.org> on 2026/07/07 06:40:36 UTC

[PR] Enforce role annotation coverage in notebook migration service [texera]

VuMartin opened a new pull request, #6217:
URL: https://github.com/apache/texera/pull/6217

   ### What changes were proposed in this PR?
   
   - Add `RoleAnnotationEnforcer.enforce(...)` to `NotebookMigrationService` after all Jersey resources are registered so role annotation coverage is validated at startup. This aligns the notebook-migration-service with the other five Dropwizard microservices that already have this guardrail.
   - Update `NotebookMigrationServiceRunSpec` to mock the Jersey `ResourceConfig` for the new startup check.
   
   ### Any related issues, documentation, discussions?
   
   Closes #6149
   Follow-up from #4904 
   
   ### How was this PR tested?
   
   Ran:
   
   ```bash
   sbt "NotebookMigrationService / testOnly *NotebookMigrationServiceRunSpec"
   ```
   
   The test passed successfully.
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: ChatGPT 5.5-mini


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Enforce role annotation coverage in notebook migration service [texera]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6217:
URL: https://github.com/apache/texera/pull/6217#issuecomment-4900903110

   <!-- texera:welcome-first-time-contributor -->
   👋 Thanks for your first contribution to Texera, @VuMartin!
   
   If you're looking for a good place to start, browse issues labeled [`starter-task`](https://github.com/apache/texera/issues?q=is%3Aissue+is%3Aopen+label%3Astarter-task); they're scoped to be approachable for newcomers.
   
   You can drive common housekeeping yourself by commenting one of these commands on its own line:
   
   - **Issues.** Comment `/take` to assign an open issue to yourself, or `/untake` to release it. You can find unclaimed work with the search filter `is:issue is:open no:assignee`.
   - **Sub-issues.** To link issues into a parent/child hierarchy, comment `/sub-issue #5166 #5222` on the parent to attach those children (or `/unsub-issue #5166 #5222` to detach them). From a child issue, comment `/parent-issue #5166` to set its parent, or `/unparent-issue` to clear it (the current parent is detected automatically). References may be written as `#5166` or as a bare `5166`; cross-repository references are not supported.
   - **Pull requests (author only).** Comment `/request-review @user` to request a review from someone, or `/unrequest-review @user` to withdraw that request.
   
   Each command must match exactly: `/take this` will not work, only `/take` does. For the full contribution flow, see [CONTRIBUTING.md](https://github.com/apache/texera/blob/main/CONTRIBUTING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Enforce role annotation coverage in notebook migration service [texera]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6217:
URL: https://github.com/apache/texera/pull/6217#issuecomment-4900904019

   <!-- texera-reviewer-suggestion -->
   ### Automated Reviewer Suggestions
   
   Based on the `git blame` history of the changed files, we recommend the following reviewers:
   
   - **Contributors with relevant context:** `@zyratlo`
     You can notify them by mentioning `@zyratlo` in a comment.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(auth): enforce role annotation coverage in notebook-migration-service [texera]

Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan merged PR #6217:
URL: https://github.com/apache/texera/pull/6217


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org