You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@whirr.apache.org by "Adrian Cole (JIRA)" <ji...@apache.org> on 2011/01/07 21:46:45 UTC
[jira] Created: (WHIRR-198) support user-defined images
support user-defined images
---------------------------
Key: WHIRR-198
URL: https://issues.apache.org/jira/browse/WHIRR-198
Project: Whirr
Issue Type: New Feature
Reporter: Adrian Cole
Whirr should be able to operate on user supplied images. Currently, this only works if the image has a default root login.
Please add a new property: whirr.login-user
if defined, override the default login user with this value.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WHIRR-198) support user-defined images
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996892#comment-12996892 ]
Andrei Savu commented on WHIRR-198:
-----------------------------------
I wanted to commit this patch but unfortunately I'm unable to run the integration tests:
{code}
2011-02-19 23:58:08,452 ERROR [org.apache.whirr.cluster.actions.BootstrapClusterAction] (pool-1-thread-1) Unexpected error while starting 2 nodes, minimum 2 nodes for [zookeeper] of cluster zkclustertest
java.util.concurrent.ExecutionException: java.lang.IllegalArgumentException: Resource must be an image (for EC2)
at java.util.concurrent.FutureTask$Sync.innerGet(FutureTask.java:222)
at java.util.concurrent.FutureTask.get(FutureTask.java:83)
at org.apache.whirr.cluster.actions.BootstrapClusterAction$StartupProcess.waitForOutcomes(BootstrapClusterAction.java:270)
at org.apache.whirr.cluster.actions.BootstrapClusterAction$StartupProcess.call(BootstrapClusterAction.java:223)
at org.apache.whirr.cluster.actions.BootstrapClusterAction$StartupProcess.call(BootstrapClusterAction.java:184)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
at java.util.concurrent.FutureTask.run(FutureTask.java:138)
at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
at java.lang.Thread.run(Thread.java:662)
Caused by: java.lang.IllegalArgumentException: Resource must be an image (for EC2)
at com.google.common.base.Preconditions.checkArgument(Preconditions.java:88)
at org.jclouds.ec2.compute.strategy.EC2PopulateDefaultLoginCredentialsForImageStrategy.execute(EC2PopulateDefaultLoginCredentialsForImageStrategy.java:50)
at org.jclouds.ec2.compute.functions.CredentialsForInstance.getLoginAccountFor(CredentialsForInstance.java:75)
at org.jclouds.ec2.compute.functions.CredentialsForInstance.apply(CredentialsForInstance.java:62)
at org.jclouds.ec2.compute.functions.CredentialsForInstance.apply(CredentialsForInstance.java:43)
at org.jclouds.ec2.compute.strategy.EC2CreateNodesInGroupThenAddToSet.populateCredentials(EC2CreateNodesInGroupThenAddToSet.java:121)
at org.jclouds.ec2.compute.strategy.EC2CreateNodesInGroupThenAddToSet.execute(EC2CreateNodesInGroupThenAddToSet.java:111)
at org.jclouds.compute.internal.BaseComputeService.createNodesInGroup(BaseComputeService.java:215)
at org.apache.whirr.cluster.actions.NodeStarter.call(BootstrapClusterAction.java:350)
at org.apache.whirr.cluster.actions.NodeStarter.call(BootstrapClusterAction.java:325)
... 5 more
{code}
> support user-defined images
> ---------------------------
>
> Key: WHIRR-198
> URL: https://issues.apache.org/jira/browse/WHIRR-198
> Project: Whirr
> Issue Type: New Feature
> Reporter: Adrian Cole
> Assignee: Adrian Cole
> Attachments: WHIRR-198.patch, WHIRR-198.patch, WHIRR-198.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Whirr should be able to operate on user supplied images. Currently, this only works if the image has a default root login.
> Please add a new property: whirr.login-user
> if defined, override the default login user with this value.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WHIRR-198) support user-defined images
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996517#comment-12996517 ]
Andrei Savu commented on WHIRR-198:
-----------------------------------
Adrian, I see no better way of doing this. I believe we should fix the patch(imports and add some documentation) and commit it to the trunk. What do you think?
> support user-defined images
> ---------------------------
>
> Key: WHIRR-198
> URL: https://issues.apache.org/jira/browse/WHIRR-198
> Project: Whirr
> Issue Type: New Feature
> Reporter: Adrian Cole
> Assignee: Adrian Cole
> Attachments: WHIRR-198.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Whirr should be able to operate on user supplied images. Currently, this only works if the image has a default root login.
> Please add a new property: whirr.login-user
> if defined, override the default login user with this value.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WHIRR-198) support user-defined images
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrei Savu updated WHIRR-198:
------------------------------
Resolution: Fixed
Fix Version/s: 0.4.0
Status: Resolved (was: Patch Available)
I've just committed this. Thanks Adrian! Sebastian, let me know if the current trunk works for you.
> support user-defined images
> ---------------------------
>
> Key: WHIRR-198
> URL: https://issues.apache.org/jira/browse/WHIRR-198
> Project: Whirr
> Issue Type: New Feature
> Reporter: Adrian Cole
> Assignee: Adrian Cole
> Fix For: 0.4.0
>
> Attachments: WHIRR-198.patch, WHIRR-198.patch, WHIRR-198.patch, WHIRR-198.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Whirr should be able to operate on user supplied images. Currently, this only works if the image has a default root login.
> Please add a new property: whirr.login-user
> if defined, override the default login user with this value.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WHIRR-198) support user-defined images
Posted by "Adrian Cole (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004736#comment-13004736 ]
Adrian Cole commented on WHIRR-198:
-----------------------------------
looking into it. stand by.
> support user-defined images
> ---------------------------
>
> Key: WHIRR-198
> URL: https://issues.apache.org/jira/browse/WHIRR-198
> Project: Whirr
> Issue Type: New Feature
> Reporter: Adrian Cole
> Assignee: Adrian Cole
> Fix For: 0.4.0
>
> Attachments: WHIRR-198.patch, WHIRR-198.patch, WHIRR-198.patch, WHIRR-198.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Whirr should be able to operate on user supplied images. Currently, this only works if the image has a default root login.
> Please add a new property: whirr.login-user
> if defined, override the default login user with this value.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WHIRR-198) support user-defined images
Posted by "Adrian Cole (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Cole updated WHIRR-198:
------------------------------
Attachment: WHIRR-198.patch
corrected package
> support user-defined images
> ---------------------------
>
> Key: WHIRR-198
> URL: https://issues.apache.org/jira/browse/WHIRR-198
> Project: Whirr
> Issue Type: New Feature
> Reporter: Adrian Cole
> Assignee: Adrian Cole
> Attachments: WHIRR-198.patch, WHIRR-198.patch, WHIRR-198.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Whirr should be able to operate on user supplied images. Currently, this only works if the image has a default root login.
> Please add a new property: whirr.login-user
> if defined, override the default login user with this value.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WHIRR-198) support user-defined images
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12993588#comment-12993588 ]
Tom White commented on WHIRR-198:
---------------------------------
Glad this helped. Are there any other changes that are needed now we're on jclouds 1.0-beta-9? The comments in the code suggest that the patch could be trimmed.
> support user-defined images
> ---------------------------
>
> Key: WHIRR-198
> URL: https://issues.apache.org/jira/browse/WHIRR-198
> Project: Whirr
> Issue Type: New Feature
> Reporter: Adrian Cole
> Assignee: Adrian Cole
> Attachments: WHIRR-198.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Whirr should be able to operate on user supplied images. Currently, this only works if the image has a default root login.
> Please add a new property: whirr.login-user
> if defined, override the default login user with this value.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WHIRR-198) support user-defined images
Posted by "Adrian Cole (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Cole updated WHIRR-198:
------------------------------
Attachment: WHIRR-198.patch
patch adds interim support for user-defined login until the following jclouds issue is resolved: http://code.google.com/p/jclouds/issues/detail?id=441
> support user-defined images
> ---------------------------
>
> Key: WHIRR-198
> URL: https://issues.apache.org/jira/browse/WHIRR-198
> Project: Whirr
> Issue Type: New Feature
> Reporter: Adrian Cole
> Assignee: Adrian Cole
> Attachments: WHIRR-198.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Whirr should be able to operate on user supplied images. Currently, this only works if the image has a default root login.
> Please add a new property: whirr.login-user
> if defined, override the default login user with this value.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (WHIRR-198) support user-defined images
Posted by "Adrian Cole (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Cole reopened WHIRR-198:
-------------------------------
resolving in a more classpath friendly way
> support user-defined images
> ---------------------------
>
> Key: WHIRR-198
> URL: https://issues.apache.org/jira/browse/WHIRR-198
> Project: Whirr
> Issue Type: New Feature
> Reporter: Adrian Cole
> Assignee: Adrian Cole
> Fix For: 0.4.0
>
> Attachments: WHIRR-198.patch, WHIRR-198.patch, WHIRR-198.patch, WHIRR-198.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Whirr should be able to operate on user supplied images. Currently, this only works if the image has a default root login.
> Please add a new property: whirr.login-user
> if defined, override the default login user with this value.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WHIRR-198) support user-defined images
Posted by "Sebastian Schoenherr (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12993470#comment-12993470 ]
Sebastian Schoenherr commented on WHIRR-198:
--------------------------------------------
Hi guys,
I just tried the patch on the latest version from svn. Had to change the import from org.jclouds.aws.ec2 to org.jclouds.ec2 but than it worked! Thanks for the great help!
Cheers
Sebastian
> support user-defined images
> ---------------------------
>
> Key: WHIRR-198
> URL: https://issues.apache.org/jira/browse/WHIRR-198
> Project: Whirr
> Issue Type: New Feature
> Reporter: Adrian Cole
> Assignee: Adrian Cole
> Attachments: WHIRR-198.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Whirr should be able to operate on user supplied images. Currently, this only works if the image has a default root login.
> Please add a new property: whirr.login-user
> if defined, override the default login user with this value.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WHIRR-198) support user-defined images
Posted by "Adrian Cole (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996542#comment-12996542 ]
Adrian Cole commented on WHIRR-198:
-----------------------------------
+1
> support user-defined images
> ---------------------------
>
> Key: WHIRR-198
> URL: https://issues.apache.org/jira/browse/WHIRR-198
> Project: Whirr
> Issue Type: New Feature
> Reporter: Adrian Cole
> Assignee: Adrian Cole
> Attachments: WHIRR-198.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Whirr should be able to operate on user supplied images. Currently, this only works if the image has a default root login.
> Please add a new property: whirr.login-user
> if defined, override the default login user with this value.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WHIRR-198) support user-defined images
Posted by "Sebastian Schoenherr (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004674#comment-13004674 ]
Sebastian Schoenherr commented on WHIRR-198:
--------------------------------------------
Hi Andrei,
sorry for my delayed reply. I've just tested this and it worked well for branch-0.4. There is a problem with the current trunk, since the overwritten class "EC2PopulateDefaultLoginCredentialsForImageStrategy" is not called anymore. Could it be a problem with the whirr-classpath? I deleted for test purpoeses the class from the ec2-1.0-beta-9b.jar with the result that the overwritten class is then called and everything works fine. (it's just a guess)
Cheers,
Sebastian
> support user-defined images
> ---------------------------
>
> Key: WHIRR-198
> URL: https://issues.apache.org/jira/browse/WHIRR-198
> Project: Whirr
> Issue Type: New Feature
> Reporter: Adrian Cole
> Assignee: Adrian Cole
> Fix For: 0.4.0
>
> Attachments: WHIRR-198.patch, WHIRR-198.patch, WHIRR-198.patch, WHIRR-198.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Whirr should be able to operate on user supplied images. Currently, this only works if the image has a default root login.
> Please add a new property: whirr.login-user
> if defined, override the default login user with this value.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Work started: (WHIRR-198) support user-defined images
Posted by "Adrian Cole (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on WHIRR-198 started by Adrian Cole.
> support user-defined images
> ---------------------------
>
> Key: WHIRR-198
> URL: https://issues.apache.org/jira/browse/WHIRR-198
> Project: Whirr
> Issue Type: New Feature
> Reporter: Adrian Cole
> Assignee: Adrian Cole
> Attachments: WHIRR-198.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Whirr should be able to operate on user supplied images. Currently, this only works if the image has a default root login.
> Please add a new property: whirr.login-user
> if defined, override the default login user with this value.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WHIRR-198) support user-defined images
Posted by "Adrian Cole (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12994802#comment-12994802 ]
Adrian Cole commented on WHIRR-198:
-----------------------------------
Andrei,
sadly the fix to http://code.google.com/p/jclouds/issues/detail?id=441 is not in beta-9. We still need a bit of validation about how to address this, and may rescope to just managing login-users, as this is typically the problem that people encounter. Care to comment about your favored approach in the above issue?
> support user-defined images
> ---------------------------
>
> Key: WHIRR-198
> URL: https://issues.apache.org/jira/browse/WHIRR-198
> Project: Whirr
> Issue Type: New Feature
> Reporter: Adrian Cole
> Assignee: Adrian Cole
> Attachments: WHIRR-198.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Whirr should be able to operate on user supplied images. Currently, this only works if the image has a default root login.
> Please add a new property: whirr.login-user
> if defined, override the default login user with this value.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WHIRR-198) support user-defined images
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrei Savu updated WHIRR-198:
------------------------------
Attachment: WHIRR-198.patch
I've updated the patch: fixed import and updated the configuration guide.
> support user-defined images
> ---------------------------
>
> Key: WHIRR-198
> URL: https://issues.apache.org/jira/browse/WHIRR-198
> Project: Whirr
> Issue Type: New Feature
> Reporter: Adrian Cole
> Assignee: Adrian Cole
> Attachments: WHIRR-198.patch, WHIRR-198.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Whirr should be able to operate on user supplied images. Currently, this only works if the image has a default root login.
> Please add a new property: whirr.login-user
> if defined, override the default login user with this value.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WHIRR-198) support user-defined images
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004679#comment-13004679 ]
Andrei Savu commented on WHIRR-198:
-----------------------------------
Thanks for testing. I've seen a similar problem while working with a private cloud based on Eucalyptus. Adrian could this be a class-path issue? Has something changed in 1.0-beta9b that could affect this patch?
> support user-defined images
> ---------------------------
>
> Key: WHIRR-198
> URL: https://issues.apache.org/jira/browse/WHIRR-198
> Project: Whirr
> Issue Type: New Feature
> Reporter: Adrian Cole
> Assignee: Adrian Cole
> Fix For: 0.4.0
>
> Attachments: WHIRR-198.patch, WHIRR-198.patch, WHIRR-198.patch, WHIRR-198.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Whirr should be able to operate on user supplied images. Currently, this only works if the image has a default root login.
> Please add a new property: whirr.login-user
> if defined, override the default login user with this value.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WHIRR-198) support user-defined images
Posted by "Adrian Cole (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Cole updated WHIRR-198:
------------------------------
Status: Patch Available (was: In Progress)
> support user-defined images
> ---------------------------
>
> Key: WHIRR-198
> URL: https://issues.apache.org/jira/browse/WHIRR-198
> Project: Whirr
> Issue Type: New Feature
> Reporter: Adrian Cole
> Assignee: Adrian Cole
> Attachments: WHIRR-198.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Whirr should be able to operate on user supplied images. Currently, this only works if the image has a default root login.
> Please add a new property: whirr.login-user
> if defined, override the default login user with this value.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WHIRR-198) support user-defined images
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12994791#comment-12994791 ]
Andrei Savu commented on WHIRR-198:
-----------------------------------
Thanks Sebastian for testing the patch. Adrian should we commit this patch (using a system property feels like a hack) or there is a better way of doing this now that jclouds 1.0-beta-9 is out?
> support user-defined images
> ---------------------------
>
> Key: WHIRR-198
> URL: https://issues.apache.org/jira/browse/WHIRR-198
> Project: Whirr
> Issue Type: New Feature
> Reporter: Adrian Cole
> Assignee: Adrian Cole
> Attachments: WHIRR-198.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Whirr should be able to operate on user supplied images. Currently, this only works if the image has a default root login.
> Please add a new property: whirr.login-user
> if defined, override the default login user with this value.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WHIRR-198) support user-defined images
Posted by "Adrian Cole (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Cole updated WHIRR-198:
------------------------------
Status: Patch Available (was: Reopened)
can you try this now? should completely remove any classpath problems
> support user-defined images
> ---------------------------
>
> Key: WHIRR-198
> URL: https://issues.apache.org/jira/browse/WHIRR-198
> Project: Whirr
> Issue Type: New Feature
> Reporter: Adrian Cole
> Assignee: Adrian Cole
> Fix For: 0.4.0
>
> Attachments: WHIRR-198.patch, WHIRR-198.patch, WHIRR-198.patch, WHIRR-198.patch, WHIRR-198.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Whirr should be able to operate on user supplied images. Currently, this only works if the image has a default root login.
> Please add a new property: whirr.login-user
> if defined, override the default login user with this value.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WHIRR-198) support user-defined images
Posted by "Sebastian Schoenherr (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005064#comment-13005064 ]
Sebastian Schoenherr commented on WHIRR-198:
--------------------------------------------
hi guys, yep it works. great! the only issue was that the class "core/src/main/java/org/jclouds/ec2/compute/strategy/EC2PopulateDefaultLoginCredentialsForImageStrategy.java" hasn't been deleted (just the content is deleted in the patch), so I got some compiliation errors, after deleting the class, I was able to compile and run it without errors.
> support user-defined images
> ---------------------------
>
> Key: WHIRR-198
> URL: https://issues.apache.org/jira/browse/WHIRR-198
> Project: Whirr
> Issue Type: New Feature
> Reporter: Adrian Cole
> Assignee: Adrian Cole
> Fix For: 0.4.0
>
> Attachments: WHIRR-198.patch, WHIRR-198.patch, WHIRR-198.patch, WHIRR-198.patch, WHIRR-198.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Whirr should be able to operate on user supplied images. Currently, this only works if the image has a default root login.
> Please add a new property: whirr.login-user
> if defined, override the default login user with this value.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WHIRR-198) support user-defined images
Posted by "Sebastian Schoenherr (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12994784#comment-12994784 ]
Sebastian Schoenherr commented on WHIRR-198:
--------------------------------------------
the patch works fine for whirr 0.3.0 without any changes. For the latest svn version the patch is still necessary and working, just the paths need to be edited (as mentioned above from org.jclouds.aws.ec2 to org.jclouds.ec2), Besides this, it worked for me.
> support user-defined images
> ---------------------------
>
> Key: WHIRR-198
> URL: https://issues.apache.org/jira/browse/WHIRR-198
> Project: Whirr
> Issue Type: New Feature
> Reporter: Adrian Cole
> Assignee: Adrian Cole
> Attachments: WHIRR-198.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Whirr should be able to operate on user supplied images. Currently, this only works if the image has a default root login.
> Please add a new property: whirr.login-user
> if defined, override the default login user with this value.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WHIRR-198) support user-defined images
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrei Savu updated WHIRR-198:
------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I've just committed this (sorry for the delay). Thanks guys! Adrian, I suggest that in the future we should avoid reopening existing issues and create new ones in order to keep the history clear.
> support user-defined images
> ---------------------------
>
> Key: WHIRR-198
> URL: https://issues.apache.org/jira/browse/WHIRR-198
> Project: Whirr
> Issue Type: New Feature
> Reporter: Adrian Cole
> Assignee: Adrian Cole
> Fix For: 0.4.0
>
> Attachments: WHIRR-198.patch, WHIRR-198.patch, WHIRR-198.patch, WHIRR-198.patch, WHIRR-198.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Whirr should be able to operate on user supplied images. Currently, this only works if the image has a default root login.
> Please add a new property: whirr.login-user
> if defined, override the default login user with this value.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (WHIRR-198) support user-defined images
Posted by "Adrian Cole (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Cole reassigned WHIRR-198:
---------------------------------
Assignee: Adrian Cole
> support user-defined images
> ---------------------------
>
> Key: WHIRR-198
> URL: https://issues.apache.org/jira/browse/WHIRR-198
> Project: Whirr
> Issue Type: New Feature
> Reporter: Adrian Cole
> Assignee: Adrian Cole
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Whirr should be able to operate on user supplied images. Currently, this only works if the image has a default root login.
> Please add a new property: whirr.login-user
> if defined, override the default login user with this value.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WHIRR-198) support user-defined images
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005082#comment-13005082 ]
Andrei Savu commented on WHIRR-198:
-----------------------------------
great! I will also give it a try and commit the patch later today. thanks.
> support user-defined images
> ---------------------------
>
> Key: WHIRR-198
> URL: https://issues.apache.org/jira/browse/WHIRR-198
> Project: Whirr
> Issue Type: New Feature
> Reporter: Adrian Cole
> Assignee: Adrian Cole
> Fix For: 0.4.0
>
> Attachments: WHIRR-198.patch, WHIRR-198.patch, WHIRR-198.patch, WHIRR-198.patch, WHIRR-198.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Whirr should be able to operate on user supplied images. Currently, this only works if the image has a default root login.
> Please add a new property: whirr.login-user
> if defined, override the default login user with this value.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WHIRR-198) support user-defined images
Posted by "Adrian Cole (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Cole updated WHIRR-198:
------------------------------
Attachment: WHIRR-198.patch
recut with the latest version of the original code in jclouds
> support user-defined images
> ---------------------------
>
> Key: WHIRR-198
> URL: https://issues.apache.org/jira/browse/WHIRR-198
> Project: Whirr
> Issue Type: New Feature
> Reporter: Adrian Cole
> Assignee: Adrian Cole
> Attachments: WHIRR-198.patch, WHIRR-198.patch, WHIRR-198.patch, WHIRR-198.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Whirr should be able to operate on user supplied images. Currently, this only works if the image has a default root login.
> Please add a new property: whirr.login-user
> if defined, override the default login user with this value.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WHIRR-198) support user-defined images
Posted by "Adrian Cole (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996895#comment-12996895 ]
Adrian Cole commented on WHIRR-198:
-----------------------------------
ahh apologies. the patch needs to be recut slightly.
stand by.
> support user-defined images
> ---------------------------
>
> Key: WHIRR-198
> URL: https://issues.apache.org/jira/browse/WHIRR-198
> Project: Whirr
> Issue Type: New Feature
> Reporter: Adrian Cole
> Assignee: Adrian Cole
> Attachments: WHIRR-198.patch, WHIRR-198.patch, WHIRR-198.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Whirr should be able to operate on user supplied images. Currently, this only works if the image has a default root login.
> Please add a new property: whirr.login-user
> if defined, override the default login user with this value.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WHIRR-198) support user-defined images
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12979329#action_12979329 ]
Andrei Savu commented on WHIRR-198:
-----------------------------------
I believe this patch could also incorporate WHIRR-158 by creating new logins. Sounds like a good idea?
> support user-defined images
> ---------------------------
>
> Key: WHIRR-198
> URL: https://issues.apache.org/jira/browse/WHIRR-198
> Project: Whirr
> Issue Type: New Feature
> Reporter: Adrian Cole
> Assignee: Adrian Cole
> Attachments: WHIRR-198.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Whirr should be able to operate on user supplied images. Currently, this only works if the image has a default root login.
> Please add a new property: whirr.login-user
> if defined, override the default login user with this value.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WHIRR-198) support user-defined images
Posted by "Adrian Cole (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Cole updated WHIRR-198:
------------------------------
Attachment: WHIRR-198.patch
this patch works without the classpath ordering problem
> support user-defined images
> ---------------------------
>
> Key: WHIRR-198
> URL: https://issues.apache.org/jira/browse/WHIRR-198
> Project: Whirr
> Issue Type: New Feature
> Reporter: Adrian Cole
> Assignee: Adrian Cole
> Fix For: 0.4.0
>
> Attachments: WHIRR-198.patch, WHIRR-198.patch, WHIRR-198.patch, WHIRR-198.patch, WHIRR-198.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Whirr should be able to operate on user supplied images. Currently, this only works if the image has a default root login.
> Please add a new property: whirr.login-user
> if defined, override the default login user with this value.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WHIRR-198) support user-defined images
Posted by "Adrian Cole (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996810#comment-12996810 ]
Adrian Cole commented on WHIRR-198:
-----------------------------------
corrected patch to use the package naming currently in jclouds beta-9
tests good
> support user-defined images
> ---------------------------
>
> Key: WHIRR-198
> URL: https://issues.apache.org/jira/browse/WHIRR-198
> Project: Whirr
> Issue Type: New Feature
> Reporter: Adrian Cole
> Assignee: Adrian Cole
> Attachments: WHIRR-198.patch, WHIRR-198.patch, WHIRR-198.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Whirr should be able to operate on user supplied images. Currently, this only works if the image has a default root login.
> Please add a new property: whirr.login-user
> if defined, override the default login user with this value.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira