You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/01/27 09:41:57 UTC
[GitHub] [incubator-dolphinscheduler] codecov-io commented on pull request #4586: [Improvement][SPI]Migrate related classes loaded by SPI classes to public modules
codecov-io commented on pull request #4586:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4586#issuecomment-768162673
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4586?src=pr&el=h1) Report
> Merging [#4586](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4586?src=pr&el=desc) (627d5c5) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/891df6d5e29ce9c3a09aaf11cdf96ab31f64ff31?el=desc) (891df6d) will **decrease** coverage by `0.04%`.
> The diff coverage is `0.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4586/graphs/tree.svg?width=650&height=150&src=pr&token=bv9iXXRLi9)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4586?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #4586 +/- ##
============================================
- Coverage 44.73% 44.69% -0.05%
+ Complexity 3343 3339 -4
============================================
Files 530 530
Lines 22838 22838
Branches 2669 2669
============================================
- Hits 10217 10207 -10
- Misses 11702 11709 +7
- Partials 919 922 +3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4586?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...org/apache/dolphinscheduler/alert/AlertServer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4586/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC9BbGVydFNlcnZlci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...phinscheduler/alert/plugin/AlertPluginManager.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4586/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC9wbHVnaW4vQWxlcnRQbHVnaW5NYW5hZ2VyLmphdmE=) | `3.03% <0.00%> (-0.10%)` | `1.00 <0.00> (ø)` | |
| [...er/common/plugin/AbstractDolphinPluginManager.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4586/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3BsdWdpbi9BYnN0cmFjdERvbHBoaW5QbHVnaW5NYW5hZ2VyLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
| [...eduler/common/plugin/DolphinPluginClassLoader.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4586/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3BsdWdpbi9Eb2xwaGluUGx1Z2luQ2xhc3NMb2FkZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...cheduler/common/plugin/DolphinPluginDiscovery.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4586/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3BsdWdpbi9Eb2xwaGluUGx1Z2luRGlzY292ZXJ5LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...inscheduler/common/plugin/DolphinPluginLoader.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4586/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3BsdWdpbi9Eb2xwaGluUGx1Z2luTG9hZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...uler/common/plugin/DolphinPluginManagerConfig.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4586/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3BsdWdpbi9Eb2xwaGluUGx1Z2luTWFuYWdlckNvbmZpZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...e/dolphinscheduler/remote/NettyRemotingClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4586/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL05ldHR5UmVtb3RpbmdDbGllbnQuamF2YQ==) | `50.00% <0.00%> (-2.78%)` | `9.00% <0.00%> (-2.00%)` | |
| [...inscheduler/common/thread/ThreadPoolExecutors.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4586/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3RocmVhZC9UaHJlYWRQb29sRXhlY3V0b3JzLmphdmE=) | `19.23% <0.00%> (-1.93%)` | `3.00% <0.00%> (-2.00%)` | |
| ... and [2 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4586/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4586?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4586?src=pr&el=footer). Last update [891df6d...627d5c5](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4586?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org