You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/01/08 03:26:28 UTC
[GitHub] [spark] zhengruifeng commented on a change in pull request #31086: [SPARK-34045][ML] OneVsRestModel.transform should not call setter of submodels
zhengruifeng commented on a change in pull request #31086:
URL: https://github.com/apache/spark/pull/31086#discussion_r553720632
##########
File path: mllib/src/test/scala/org/apache/spark/ml/classification/OneVsRestSuite.scala
##########
@@ -210,6 +210,19 @@ class OneVsRestSuite extends MLTest with DefaultReadWriteTest {
assert(ova2.fit(dataset2) !== null)
}
+ test("SPARK-34045: OneVsRestModel.transform should not call setter of submodels") {
Review comment:
this will fail in master:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org