You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2017/10/27 17:09:11 UTC

[GitHub] sijie commented on a change in pull request #671: WIP - BP-14 Relax Durability - patch 2 - force() API for FORCE_DEFERRED_ON_JOURNAL LedgerType

sijie commented on a change in pull request #671: WIP - BP-14 Relax Durability - patch 2 - force() API for FORCE_DEFERRED_ON_JOURNAL LedgerType
URL: https://github.com/apache/bookkeeper/pull/671#discussion_r147460356
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java
 ##########
 @@ -772,65 +779,66 @@ private String getMyId() throws UnknownHostException {
 
     void readJournal() throws IOException, BookieException {
         long startTs = MathUtils.now();
-        JournalScanner scanner = new JournalScanner() {
 
 Review comment:
   It is good not to do this kind of the reformat/refactor change in a large pull request. it is a bit hard for me to figure out which line was actually changed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services