You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "James Dyer (Created) (JIRA)" <ji...@apache.org> on 2012/04/16 23:12:18 UTC
[jira] [Created] (SOLR-3361) "maxNumberOfBackups" does not work
with "backupAfter"=commit
"maxNumberOfBackups" does not work with "backupAfter"=commit
------------------------------------------------------------
Key: SOLR-3361
URL: https://issues.apache.org/jira/browse/SOLR-3361
Project: Solr
Issue Type: Bug
Components: replication (java)
Affects Versions: 3.6
Reporter: James Dyer
Assignee: James Dyer
Priority: Minor
Fix For: 4.0, 3.6.1
Tomás Fernández Löbbe reported on SOLR-3033 that when specifying the init parameter combination "maxNumberOfBackups" with "backupAfter"=commit, the backups do not get cleaned up.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-3361) "maxNumberOfBackups" does not work
with "backupAfter"=commit
Posted by "James Dyer (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Dyer updated SOLR-3361:
-----------------------------
Attachment: SOLR-3361-failingtest.patch
Tomas provided this test on SOLR-3033.
> "maxNumberOfBackups" does not work with "backupAfter"=commit
> ------------------------------------------------------------
>
> Key: SOLR-3361
> URL: https://issues.apache.org/jira/browse/SOLR-3361
> Project: Solr
> Issue Type: Bug
> Components: replication (java)
> Affects Versions: 3.6
> Reporter: James Dyer
> Assignee: James Dyer
> Priority: Minor
> Fix For: 4.0, 3.6.1
>
> Attachments: SOLR-3361-failingtest.patch, SOLR-3361.patch
>
>
> Tomás Fernández Löbbe reported on SOLR-3033 that when specifying the init parameter combination "maxNumberOfBackups" with "backupAfter"=commit, the backups do not get cleaned up.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-3361) "maxNumberOfBackups" does not work
with "backupAfter"=commit
Posted by "James Dyer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Dyer updated SOLR-3361:
-----------------------------
Attachment: SOLR-3361.patch
Here's a patch that has both a fix and an improved unit test. There are basically 3 scenarios, all of which now get tested:
1. User does an interactive command with the "numberToKeep" request param.
2. User has "maxBackupsToKeep" in their configuration but it still doing backups using the interactive command.
3. User is relying on commits to do backups automatically.
I will commit to Trunk and 3.x (3.6.1) shortly.
> "maxNumberOfBackups" does not work with "backupAfter"=commit
> ------------------------------------------------------------
>
> Key: SOLR-3361
> URL: https://issues.apache.org/jira/browse/SOLR-3361
> Project: Solr
> Issue Type: Bug
> Components: replication (java)
> Affects Versions: 3.6
> Reporter: James Dyer
> Assignee: James Dyer
> Priority: Minor
> Fix For: 4.0, 3.6.1
>
> Attachments: SOLR-3361-failingtest.patch, SOLR-3361.patch, SOLR-3361.patch
>
>
> Tomás Fernández Löbbe reported on SOLR-3033 that when specifying the init parameter combination "maxNumberOfBackups" with "backupAfter"=commit, the backups do not get cleaned up.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-3361) "maxNumberOfBackups" does not work
with "backupAfter"=commit
Posted by "James Dyer (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Dyer updated SOLR-3361:
-----------------------------
Attachment: SOLR-3361.patch
here is the fix. I had not created a unit test for this to prevent the ReplicationHandler test taking even longer to complete. Bad idea as commits handle the backup in an entirely different code branch than the one I had originally modified!
> "maxNumberOfBackups" does not work with "backupAfter"=commit
> ------------------------------------------------------------
>
> Key: SOLR-3361
> URL: https://issues.apache.org/jira/browse/SOLR-3361
> Project: Solr
> Issue Type: Bug
> Components: replication (java)
> Affects Versions: 3.6
> Reporter: James Dyer
> Assignee: James Dyer
> Priority: Minor
> Fix For: 4.0, 3.6.1
>
> Attachments: SOLR-3361-failingtest.patch, SOLR-3361.patch
>
>
> Tomás Fernández Löbbe reported on SOLR-3033 that when specifying the init parameter combination "maxNumberOfBackups" with "backupAfter"=commit, the backups do not get cleaned up.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (SOLR-3361) "maxNumberOfBackups" does not work
with "backupAfter"=commit
Posted by "James Dyer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Dyer resolved SOLR-3361.
------------------------------
Resolution: Fixed
Committed.
Trunk: r1329337
3.6 Branch: r1329351
Also put a note on the wiki that 3.6.0 users will need this patch for this to work with "backupAfter".
Thanks Tomas.
> "maxNumberOfBackups" does not work with "backupAfter"=commit
> ------------------------------------------------------------
>
> Key: SOLR-3361
> URL: https://issues.apache.org/jira/browse/SOLR-3361
> Project: Solr
> Issue Type: Bug
> Components: replication (java)
> Affects Versions: 3.6
> Reporter: James Dyer
> Assignee: James Dyer
> Priority: Minor
> Fix For: 4.0, 3.6.1
>
> Attachments: SOLR-3361-failingtest.patch, SOLR-3361.patch, SOLR-3361.patch
>
>
> Tomás Fernández Löbbe reported on SOLR-3033 that when specifying the init parameter combination "maxNumberOfBackups" with "backupAfter"=commit, the backups do not get cleaned up.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org