You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by redsanket <gi...@git.apache.org> on 2016/12/21 21:18:27 UTC
[GitHub] storm pull request #1837: [STORM-2254] Provide Socket time out for nimbus th...
GitHub user redsanket opened a pull request:
https://github.com/apache/storm/pull/1837
[STORM-2254] Provide Socket time out for nimbus thrift client
For DRPC we have seen during our integration tests that the connection needs to be up for more than 10 minutes so not adding any timeout for it.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/redsanket/storm STORM-2254
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1837.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1837
----
commit 3da11a2723213f0b1788c9b5766226124c1f4297
Author: Sanket <sc...@untilservice-lm>
Date: 2016-12-21T21:08:12Z
Provide Socket time out for nimbus thrift client
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1837: [STORM-2254] Provide Socket time out for nimbus th...
Posted by hmcl <gi...@git.apache.org>.
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1837#discussion_r93810498
--- Diff: storm-core/src/jvm/org/apache/storm/security/auth/SaslTransportPlugin.java ---
@@ -64,8 +64,14 @@ public void prepare(ThriftConnectionType type, Map storm_conf, Configuration log
@Override
public TServer getServer(TProcessor processor) throws IOException, TTransportException {
int port = type.getPort(storm_conf);
+ Integer socketTimeout = type.getSocketTimeOut(storm_conf);
TTransportFactory serverTransportFactory = getServerTransportFactory();
- TServerSocket serverTransport = new TServerSocket(port);
+ TServerSocket serverTransport = null;
+ if (socketTimeout != null) {
--- End diff --
if socketTimeout is defined in defaults.yaml, how can it ever be null ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1837: [STORM-2254] Provide Socket time out for nimbus th...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1837
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1837: [STORM-2254] Provide Socket time out for nimbus th...
Posted by redsanket <gi...@git.apache.org>.
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/1837#discussion_r94053490
--- Diff: storm-core/src/jvm/org/apache/storm/security/auth/SaslTransportPlugin.java ---
@@ -64,8 +64,14 @@ public void prepare(ThriftConnectionType type, Map storm_conf, Configuration log
@Override
public TServer getServer(TProcessor processor) throws IOException, TTransportException {
int port = type.getPort(storm_conf);
+ Integer socketTimeout = type.getSocketTimeOut(storm_conf);
TTransportFactory serverTransportFactory = getServerTransportFactory();
- TServerSocket serverTransport = new TServerSocket(port);
+ TServerSocket serverTransport = null;
+ if (socketTimeout != null) {
--- End diff --
For NIMBUS thrift client it is not null but for DRPC there is a possibility of it being null
as per since the DRPC intialization here is null. Refering to https://github.com/apache/storm/pull/1837/files#diff-8a40b66d685fb8c7b58cfaba6272e14aR82
and https://github.com/apache/storm/pull/1837/files#diff-8a40b66d685fb8c7b58cfaba6272e14aR82
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1837: [STORM-2254] Provide Socket time out for nimbus thrift cl...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1837
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---