[plc4x] branch develop updated: - Aded the download of the KNX master-data to the build.

[cd...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

cdutz pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/plc4x.git


The following commit(s) were added to refs/heads/develop by this push:
     new fd30802  - Aded the download of the KNX master-data to the build.
fd30802 is described below

commit fd308021c9343244373f17624ad27eca317aa9e2
Author: cdutz <ch...@c-ware.de>
AuthorDate: Wed Dec 16 14:14:36 2020 +0100

    - Aded the download of the KNX master-data to the build.
---
 protocols/knxnetip/pom.xml                         | 25 ++++++++++++++++++++++
 .../resources/protocols/knxnetip/knxnetip.mspec    |  3 +++
 2 files changed, 28 insertions(+)

diff --git a/protocols/knxnetip/pom.xml b/protocols/knxnetip/pom.xml
index db40987..3a3458f 100644
--- a/protocols/knxnetip/pom.xml
+++ b/protocols/knxnetip/pom.xml
@@ -32,6 +32,31 @@
   <name>Protocols: KNXNet/IP</name>
   <description>Base protocol specifications for the KNXNet/IP protocol</description>
 
+  <build>
+    <plugins>
+      <!-- Fetch the master-data which will be used to translate manufacturer ids to readable names -->
+      <plugin>
+        <groupId>com.googlecode.maven-download-plugin</groupId>
+        <artifactId>download-maven-plugin</artifactId>
+        <executions>
+          <execution>
+            <id>fetch-knx-manufacturer-data</id>
+            <phase>generate-resources</phase>
+            <goals>
+              <goal>wget</goal>
+            </goals>
+            <configuration>
+              <url>https://update.knx.org/data/XML/project-20/knx_master.xml</url>
+              <unpack>false</unpack>
+              <outputDirectory>${project.build.outputDirectory}/protocols/knxnetip</outputDirectory>
+              <outputFileName>knx-master-data.xml</outputFileName>
+            </configuration>
+          </execution>
+        </executions>
+      </plugin>
+    </plugins>
+  </build>
+
   <dependencies>
     <dependency>
       <groupId>org.apache.plc4x</groupId>
diff --git a/protocols/knxnetip/src/main/resources/protocols/knxnetip/knxnetip.mspec b/protocols/knxnetip/src/main/resources/protocols/knxnetip/knxnetip.mspec
index d22fd72..48cc6a1 100644
--- a/protocols/knxnetip/src/main/resources/protocols/knxnetip/knxnetip.mspec
+++ b/protocols/knxnetip/src/main/resources/protocols/knxnetip/knxnetip.mspec
@@ -218,12 +218,15 @@
         ['0x04' KnxNetIpTunneling
             [simple uint 8 'version']
         ]
+        // TODO: Check if this shouldn't be KnxNetIp instead of KnxNet
         ['0x06' KnxNetRemoteLogging
             [simple uint 8 'version']
         ]
+        // TODO: Check if this shouldn't be KnxNetIp instead of KnxNet
         ['0x07' KnxNetRemoteConfigurationAndDiagnosis
             [simple uint 8 'version']
         ]
+        // TODO: Check if this shouldn't be KnxNetIp instead of KnxNet
         ['0x08' KnxNetObjectServer
             [simple uint 8 'version']
         ]