You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2020/12/09 04:36:13 UTC
[GitHub] [accumulo] ctubbsii opened a new pull request #1831: Remove a redundant audit message
ctubbsii opened a new pull request #1831:
URL: https://github.com/apache/accumulo/pull/1831
This fixes #1827 correctly this time, after that incorrect fix was
reverted.
* Reverse order of checks, so that checking to see if a user has the
SYSTEM permission is only done if the user is not authenticating
themselves; this removes a redundant audit message indicating that the
user does not have the SYSTEM permission when it isn't necessary to
check for that in the first place
* Ensure that the current user is always authenticated first, regardless
of whether we check if the user is authenticating themselves or if
they are authenticating another user using their SYSTEM permissions
* Inline the unneeded method and add comments to significantly improve
the readability of the code
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on pull request #1831: Remove a redundant audit message
Posted by GitBox <gi...@apache.org>.
milleruntime commented on pull request #1831:
URL: https://github.com/apache/accumulo/pull/1831#issuecomment-741999962
Should this be back-ported to 1.10?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on pull request #1831: Remove a redundant audit message
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #1831:
URL: https://github.com/apache/accumulo/pull/1831#issuecomment-742077901
> Should this be back-ported to 1.10?
I don't think so. It's not that important. It's just an extra log message that doesn't matter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii merged pull request #1831: Remove a redundant audit message
Posted by GitBox <gi...@apache.org>.
ctubbsii merged pull request #1831:
URL: https://github.com/apache/accumulo/pull/1831
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org