[GitHub] [spark] viirya commented on a diff in pull request #42138: [SPARK-44534][K8S] Handle only shuffle files in KubernetesLocalDiskShuffleExecutorComponents

["viirya (via GitHub)" <gi...@apache.org>]

viirya commented on code in PR #42138:
URL: https://github.com/apache/spark/pull/42138#discussion_r1272865121


##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/shuffle/KubernetesLocalDiskShuffleExecutorComponents.scala:
##########
@@ -98,8 +98,11 @@ object KubernetesLocalDiskShuffleExecutorComponents extends Logging {
       logInfo(s"Try to recover ${f.getAbsolutePath}")
       try {
         val id = BlockId(f.getName)
-        val decryptedSize = f.length()
-        bm.TempFileBasedBlockStoreUpdater(id, level, classTag, f, decryptedSize).save()
+        // To make it sure to handle only shuffle blocks
+        if (id.isShuffle) {
+          val decryptedSize = f.length()
+          bm.TempFileBasedBlockStoreUpdater(id, level, classTag, f, decryptedSize).save()
+        }

Review Comment:
   Do we need to log it? For example we did log for `UnrecognizedBlockId` below.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org