You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@openwhisk.apache.org by gi...@git.apache.org on 2017/10/16 17:44:27 UTC

[GitHub] mrutkows commented on issue #608: Invalid Runtime not detected / no error generated

mrutkows commented on issue #608: Invalid Runtime not detected / no error generated
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/608#issuecomment-336966727
 
 
   In addition, issue #306 lists what we SHOULD do (copied below), but I am not confident we test for many of these conditions:
   
   ```
       verify the kind (if it has one) a valid extension ":default" as part if the string OR
       verify it has a valid version number, for example ":6" or ":3"
       Notify user with a specific error saying "Specified runtime (kind) is not recognized as being valid" along with the line number in the manifest where this was parsed.
       Allow simple "java" as a value and assume we default to "latest", that is we treat it like "java:default" instead.
       FEATURE: if the user specifies a valid kind runtime:nodejs:4 but the version is not recognized we should look to interactively prompt the user asking if they want to continue with the latest "default" for that runtime kind (PLEASE OPEN A NEW ISSUE FOR THIS INTERACTIVE MODE).
       FEATURE: we should perhaps call the CLI to list the known runtimes and not hardcode a list at all and use the JSON response to derive a list of valid runtime (kinds) AND we should provide WARNINGS to the user of the runtimes are marked "deprecated". (PLEASE OPEN A NEW ISSUE FOR FEATURE).
   
   and if we do not find a runtime key at all in the manifest we should of course still "default" to "nodejs:default", BUT WE SHOULD PRESENT A WARNING in the output to the user that we are making this assumption.
   ```
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services