You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "frankvicky (via GitHub)" <gi...@apache.org> on 2024/08/02 03:04:41 UTC
[PR] KAFKA-17238: Move VoterSet and ReplicaKey from raft.internals to raft [kafka]
frankvicky opened a new pull request, #16775:
URL: https://github.com/apache/kafka/pull/16775
[JIRA Link](https://issues.apache.org/jira/browse/KAFKA-17238)
VoterSet should be part of the public API since it is used by the Formatter and it is exposed in the RecordsSnapshotWriter.Builder.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17238: Move VoterSet and ReplicaKey from raft.internals to raft [kafka]
Posted by "frankvicky (via GitHub)" <gi...@apache.org>.
frankvicky commented on PR #16775:
URL: https://github.com/apache/kafka/pull/16775#issuecomment-2286546993
Hi @chia7712
I have fixed the conflicts, PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17238: Move VoterSet and ReplicaKey from raft.internals to raft [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #16775:
URL: https://github.com/apache/kafka/pull/16775#issuecomment-2291712475
push to 3.9 (https://github.com/apache/kafka/commit/bcf4c73bae59d0425417c24fd526a3a232f6f640)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17238: Move VoterSet and ReplicaKey from raft.internals to raft [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #16775:
URL: https://github.com/apache/kafka/pull/16775
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17238: Move VoterSet and ReplicaKey from raft.internals to raft [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #16775:
URL: https://github.com/apache/kafka/pull/16775#issuecomment-2291696880
> thanks for the improvements but can we try avoiding this kind of changes until after 3.9.0 RC?
This kind of changes tend to cause unnecessary churn on pending PRs that need to get merged to trunk and 3.9.
I planed to wait it but I saw the email of 3.9.0 says it is ok to refactor ... ok, this is my excuse. I should wait it until after 3.9.0 RC
> are you planning to cherry-pick this to the 3.9 branch? I say we cherry-pick it. It is trivial and may save some conflicts in future cherry-picks to 3.9.
sure. Let me fix my rush
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17238: Move VoterSet and ReplicaKey from raft.internals to raft [kafka]
Posted by "frankvicky (via GitHub)" <gi...@apache.org>.
frankvicky commented on PR #16775:
URL: https://github.com/apache/kafka/pull/16775#issuecomment-2291725574
Hi @jsancio
Apologies for the timing of this PR. I should have waited until after the 3.9.0 RC before submitting it. I’ll be more mindful of the timing in the future to avoid any impact on others’ work. Thanks for understanding. 🙇
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17238: Move VoterSet and ReplicaKey from raft.internals to raft [kafka]
Posted by "jsancio (via GitHub)" <gi...@apache.org>.
jsancio commented on PR #16775:
URL: https://github.com/apache/kafka/pull/16775#issuecomment-2291677673
@frankvicky @chia7712 thanks for the improvements but can we try avoiding this kind of changes until after 3.9.0 RC?
This kind of changes tend to cause unnecessary churn on pending PRs that need to get merged to trunk and 3.9.
@chia7712 are you planning to cherry-pick this to the 3.9 branch? I say we cherry-pick it. It is trivial and may save some conflicts in future cherry-picks to 3.9.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17238: Move VoterSet and ReplicaKey from raft.internals to raft [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #16775:
URL: https://github.com/apache/kafka/pull/16775#issuecomment-2286510457
@frankvicky could you please fix the conflicts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17238: Move VoterSet and ReplicaKey from raft.internals to raft [kafka]
Posted by "frankvicky (via GitHub)" <gi...@apache.org>.
frankvicky commented on PR #16775:
URL: https://github.com/apache/kafka/pull/16775#issuecomment-2267228317
Cool
I will resolve the conflict after 3.9 release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17238: Move VoterSet and ReplicaKey from raft.internals to raft [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #16775:
URL: https://github.com/apache/kafka/pull/16775#issuecomment-2267095271
@frankvicky see the comment on the jira, and I will take a look at this PR after 3.9.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org