You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/02 20:28:23 UTC
[GitHub] [arrow] kou commented on pull request #12320: ARROW-15483: [Release] Revamp the verification scripts
kou commented on pull request #12320:
URL: https://github.com/apache/arrow/pull/12320#issuecomment-1057347095
It's just a test problem not implementation. We can accept Ruby 2.5 with the following patch:
```diff
diff --git a/ruby/red-arrow/test/test-table.rb b/ruby/red-arrow/test/test-table.rb
index 5d039c9cfa..2cdccb95fd 100644
--- a/ruby/red-arrow/test/test-table.rb
+++ b/ruby/red-arrow/test/test-table.rb
@@ -186,7 +186,12 @@ class TableTest < Test::Unit::TestCase
end
test("{key: Range}: beginless include end") do
- assert_equal(<<-TABLE, @table.slice(count: ..8).to_s)
+ begin
+ range = eval("..8")
+ rescue SyntaxError
+ omit("beginless range isn't supported")
+ end
+ assert_equal(<<-TABLE, @table.slice(count: range).to_s)
count visible
0 1 true
1 2 false
@@ -196,7 +201,12 @@ class TableTest < Test::Unit::TestCase
end
test("{key: Range}: beginless exclude end") do
- assert_equal(<<-TABLE, @table.slice(count: ...8).to_s)
+ begin
+ range = eval("...8")
+ rescue SyntaxError
+ omit("beginless range isn't supported")
+ end
+ assert_equal(<<-TABLE, @table.slice(count: range).to_s)
count visible
0 1 true
1 2 false
@@ -205,7 +215,12 @@ class TableTest < Test::Unit::TestCase
end
test("{key: Range}: endless") do
- assert_equal(<<-TABLE, @table.slice(count: 16..).to_s)
+ begin
+ range = eval("16..")
+ rescue SyntaxError
+ omit("endless range isn't supported")
+ end
+ assert_equal(<<-TABLE, @table.slice(count: range).to_s)
count visible
0 16 true
1 32 false
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org