You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/05/09 01:43:04 UTC

[jira] [Commented] (SAMZA-1272) ZkCoordinationUtils deletes the entire Zk tree on reset

    [ https://issues.apache.org/jira/browse/SAMZA-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16001907#comment-16001907 ] 

ASF GitHub Bot commented on SAMZA-1272:
---------------------------------------

GitHub user navina opened a pull request:

    https://github.com/apache/samza/pull/173

    SAMZA-1272 : ZkCoordinationUtils deletes the entire Zk tree on reset

    * ZkCoordinationUtils has a reset interface that deletes the entire Zk tree. This is not desirable.
    * Also, fixed flakiness in unit test by unique barrier name in each of the unit tests. Otherwise, they share the same path on Zk and fail during concurrent test execution


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/navina/samza SAMZA-1272

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/samza/pull/173.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #173
    
----
commit a2cf394c555ca93a6d654edfb6a0b44273dc7b1b
Author: Navina Ramesh <na...@apache.org>
Date:   2017-05-09T00:31:18Z

    Blah

commit 52da0c76af503e5d6d27ada8011cc78a987e90eb
Author: Navina Ramesh <na...@apache.org>
Date:   2017-05-09T01:39:49Z

    Fixing the unit test for barrier

----


> ZkCoordinationUtils deletes the entire Zk tree on reset
> -------------------------------------------------------
>
>                 Key: SAMZA-1272
>                 URL: https://issues.apache.org/jira/browse/SAMZA-1272
>             Project: Samza
>          Issue Type: Bug
>            Reporter: Navina Ramesh
>            Assignee: Navina Ramesh
>             Fix For: 0.13.0
>
>
> ZkCoordinationUtils has a _reset_ interface that deletes the entire Zk tree. 
> The example application seems to work fine because only the _LocalApplicationRunner_ invokes it and the root gets created again. But this is not the expected behavior. The LocalApplicationRunner is responsible for creating the ZkRoot and every other component down the stack should work under this root.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)