[GitHub] [solr] stillalex commented on a diff in pull request #1856: SOLR-16943 Move Jetty HttpClient tracing into InstrumentedHttpListenerFactory

["stillalex (via GitHub)" <gi...@apache.org>]

stillalex commented on code in PR #1856:
URL: https://github.com/apache/solr/pull/1856#discussion_r1301564710


##########
solr/core/src/java/org/apache/solr/util/stats/InstrumentedHttpListenerFactory.java:
##########
@@ -86,19 +89,36 @@ private static String methodNameString(Request request) {
   public RequestResponseListener get() {
     return new RequestResponseListener() {
       Timer.Context timerContext;
+      Span span = Span.getInvalid();
+
+      @Override
+      public void onQueued(Request request) {
+        // do tracing onQueued because it's called from Solr's thread
+        var textMapPropagator = TraceUtils.getTextMapPropagator();

Review Comment:
   why not use `TraceUtils.injectContextIntoRequest`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org