You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by keval bhatt <kb...@apache.org> on 2017/08/21 12:18:59 UTC
Review Request 61780: ATLAS-2073 : UI : In search page removing tag
or type from drop-down will not exclude respective filters
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61780/
-----------------------------------------------------------
Review request for atlas, Apoorv Naik, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
Bugs: ATLAS-2073
https://issues.apache.org/jira/browse/ATLAS-2073
Repository: atlas
Description
-------
Step to reproduce.
* Select tag from drop-down and apply filters and search
* Now deselect tag from drop-down using cross icon and search
* Error will shown "TagFilters specified without tag name"
Diffs
-----
dashboardv2/public/js/router/Router.js 4fac9c9
dashboardv2/public/js/views/search/SearchLayoutView.js 5957a46
Diff: https://reviews.apache.org/r/61780/diff/1/
Testing
-------
done one round of sanity test
Thanks,
keval bhatt
Re: Review Request 61780: ATLAS-2073 : UI : In search page removing
tag or type from drop-down will not exclude respective filters
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61780/#review183350
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Aug. 21, 2017, 12:18 p.m., keval bhatt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61780/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2017, 12:18 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-2073
> https://issues.apache.org/jira/browse/ATLAS-2073
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Step to reproduce.
>
> * Select tag from drop-down and apply filters and search
> * Now deselect tag from drop-down using cross icon and search
> * Error will shown "TagFilters specified without tag name"
>
>
> Diffs
> -----
>
> dashboardv2/public/js/router/Router.js 4fac9c9
> dashboardv2/public/js/views/search/SearchLayoutView.js 5957a46
>
>
> Diff: https://reviews.apache.org/r/61780/diff/1/
>
>
> Testing
> -------
>
> done one round of sanity test
>
>
> Thanks,
>
> keval bhatt
>
>