You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jclouds.apache.org by Everett Toews <no...@github.com> on 2013/12/16 20:56:05 UTC

[jclouds] Ensure the accessIPv4 value gets into NodeMetadata. (#236)

https://issues.apache.org/jira/browse/JCLOUDS-355
You can merge this Pull Request by running:

  git pull https://github.com/rackspace/jclouds access-ipv4-in-nodemetadata

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds/pull/236

-- Commit Summary --

  * Ensure the accessIPv4 value gets into NodeMetadata.

-- File Changes --

    M apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/compute/functions/ServerInZoneToNodeMetadata.java (35)
    M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/compute/functions/ServerInZoneToNodeMetadataTest.java (104)
    M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/parse/ParseServerTest.java (8)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/236.patch
https://github.com/jclouds/jclouds/pull/236.diff

Re: [jclouds] Ensure the accessIPv4 value gets into NodeMetadata. (#236)

Posted by CloudBees pull request builder plugin <no...@github.com>.

[jclouds-pull-requests #478](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/478/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/236#issuecomment-30698372

Re: [jclouds] Ensure the accessIPv4 value gets into NodeMetadata. (#236)

Posted by CloudBees pull request builder plugin <no...@github.com>.

[jclouds-java-7-pull-requests #941](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/941/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/236#issuecomment-30698790

Re: [jclouds] Ensure the accessIPv4 value gets into NodeMetadata. (#236)

Posted by Andrew Bayer <no...@github.com>.

Looks reasonable to me.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/236#issuecomment-30694420

Re: [jclouds] Ensure the accessIPv4 value gets into NodeMetadata. (#236)

Posted by Andrew Phillips <no...@github.com>.

Looks good to me, too - thanks, @everett-toews!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/236#issuecomment-30720506