You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Sijie Guo (JIRA)" <ji...@apache.org> on 2012/05/10 07:48:02 UTC
[jira] [Created] (BOOKKEEPER-251) Noise error message printed when
scanning entry log files those have been garbage collected.
Sijie Guo created BOOKKEEPER-251:
------------------------------------
Summary: Noise error message printed when scanning entry log files those have been garbage collected.
Key: BOOKKEEPER-251
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-251
Project: Bookkeeper
Issue Type: Improvement
Components: bookkeeper-server
Affects Versions: 4.1.0
Reporter: Sijie Guo
Fix For: 4.1.0
currently, due to the messy scan mechanism deployed by garbage collector thread. following noise error message would be printed when scanning those entry log files has been garbage collected.
{quote}
2012-05-09 15:58:52,742 - INFO [GarbageCollectorThread:GarbageCollectorThread@466] - Extracting entry log meta from entryLogId: 0
2012-05-09 15:58:52,743 - WARN [GarbageCollectorThread:EntryLogger@386] - Failed to get channel to scan entry log: 0.log
2012-05-09 15:58:52,743 - WARN [GarbageCollectorThread:GarbageCollectorThread@473] - Premature exception when processing 0recovery will take care of the problem
java.io.FileNotFoundException: No file for log 0
at org.apache.bookkeeper.bookie.EntryLogger.findFile(EntryLogger.java:366)
at org.apache.bookkeeper.bookie.EntryLogger.getChannelForLogId(EntryLogger.java:340)
at org.apache.bookkeeper.bookie.EntryLogger.scanEntryLog(EntryLogger.java:384)
at org.apache.bookkeeper.bookie.GarbageCollectorThread.extractMetaFromEntryLog(GarbageCollectorThread.java:485)
at org.apache.bookkeeper.bookie.GarbageCollectorThread.extractMetaFromEntryLogs(GarbageCollectorThread.java:470)
at org.apache.bookkeeper.bookie.GarbageCollectorThread.run(GarbageCollectorThread.java:189)
{quote}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-251) Noise error message printed when
scanning entry log files those have been garbage collected.
Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sijie Guo updated BOOKKEEPER-251:
---------------------------------
Attachment: BK-251.diff_v3
attach a new patch renaming isLogExisted to logExists.
> Noise error message printed when scanning entry log files those have been garbage collected.
> --------------------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-251
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-251
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-server
> Affects Versions: 4.1.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.1.0
>
> Attachments: BK-251.diff, BK-251.diff_v2, BK-251.diff_v3
>
>
> currently, due to the messy scan mechanism deployed by garbage collector thread. following noise error message would be printed when scanning those entry log files has been garbage collected.
> {quote}
> 2012-05-09 15:58:52,742 - INFO [GarbageCollectorThread:GarbageCollectorThread@466] - Extracting entry log meta from entryLogId: 0
> 2012-05-09 15:58:52,743 - WARN [GarbageCollectorThread:EntryLogger@386] - Failed to get channel to scan entry log: 0.log
> 2012-05-09 15:58:52,743 - WARN [GarbageCollectorThread:GarbageCollectorThread@473] - Premature exception when processing 0recovery will take care of the problem
> java.io.FileNotFoundException: No file for log 0
> at org.apache.bookkeeper.bookie.EntryLogger.findFile(EntryLogger.java:366)
> at org.apache.bookkeeper.bookie.EntryLogger.getChannelForLogId(EntryLogger.java:340)
> at org.apache.bookkeeper.bookie.EntryLogger.scanEntryLog(EntryLogger.java:384)
> at org.apache.bookkeeper.bookie.GarbageCollectorThread.extractMetaFromEntryLog(GarbageCollectorThread.java:485)
> at org.apache.bookkeeper.bookie.GarbageCollectorThread.extractMetaFromEntryLogs(GarbageCollectorThread.java:470)
> at org.apache.bookkeeper.bookie.GarbageCollectorThread.run(GarbageCollectorThread.java:189)
> {quote}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-251) Noise error message printed when
scanning entry log files those have been garbage collected.
Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sijie Guo updated BOOKKEEPER-251:
---------------------------------
Attachment: BK-251.diff
add a patch to remove noise warn messages.
1) check whether the log id is existed or not before scanning it. so we don't need to scan those garbage collected log files.
2) track the last log id we have scanned, we don't need to scan those entry log id before it.
> Noise error message printed when scanning entry log files those have been garbage collected.
> --------------------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-251
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-251
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-server
> Affects Versions: 4.1.0
> Reporter: Sijie Guo
> Fix For: 4.1.0
>
> Attachments: BK-251.diff
>
>
> currently, due to the messy scan mechanism deployed by garbage collector thread. following noise error message would be printed when scanning those entry log files has been garbage collected.
> {quote}
> 2012-05-09 15:58:52,742 - INFO [GarbageCollectorThread:GarbageCollectorThread@466] - Extracting entry log meta from entryLogId: 0
> 2012-05-09 15:58:52,743 - WARN [GarbageCollectorThread:EntryLogger@386] - Failed to get channel to scan entry log: 0.log
> 2012-05-09 15:58:52,743 - WARN [GarbageCollectorThread:GarbageCollectorThread@473] - Premature exception when processing 0recovery will take care of the problem
> java.io.FileNotFoundException: No file for log 0
> at org.apache.bookkeeper.bookie.EntryLogger.findFile(EntryLogger.java:366)
> at org.apache.bookkeeper.bookie.EntryLogger.getChannelForLogId(EntryLogger.java:340)
> at org.apache.bookkeeper.bookie.EntryLogger.scanEntryLog(EntryLogger.java:384)
> at org.apache.bookkeeper.bookie.GarbageCollectorThread.extractMetaFromEntryLog(GarbageCollectorThread.java:485)
> at org.apache.bookkeeper.bookie.GarbageCollectorThread.extractMetaFromEntryLogs(GarbageCollectorThread.java:470)
> at org.apache.bookkeeper.bookie.GarbageCollectorThread.run(GarbageCollectorThread.java:189)
> {quote}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-251) Noise error message printed
when scanning entry log files those have been garbage collected.
Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272285#comment-13272285 ]
Sijie Guo commented on BOOKKEEPER-251:
--------------------------------------
@Ivan, I would change isLogExisted to logExists.
@Flavio,
before the patch, extractMetaFromEntryLogs would scan entry log files from 0, if the log file has been scanned but not deleted, it would skip scanning. but if the log file has been garbage collected, it is not in entryLogMetaMap. it would be scanned again, so it would hit try-catch block to print the error message.
the patch did two things:
1) it would check the log file existed or not before proceeding scanning the file. if the log file is not existed, it means that the log file is garbage collected. we skip it. actually I don't think we need to keep a list of garbage collected entry logs, since the non-existed entry log file might be garbage collected before.
2) it records the last entry log id that we have scanned, so we don't need to start from zero again. just improve 1) to avoid checking the existence of entry log file again and again.
After applying this patch, the message only occurred when failed to scan an entry log due to IOException. it might be due to data corruption in that entry log file. I think the log message is OK, but if you have a better one to suggest, it would be great to change it.
> Noise error message printed when scanning entry log files those have been garbage collected.
> --------------------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-251
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-251
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-server
> Affects Versions: 4.1.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.1.0
>
> Attachments: BK-251.diff
>
>
> currently, due to the messy scan mechanism deployed by garbage collector thread. following noise error message would be printed when scanning those entry log files has been garbage collected.
> {quote}
> 2012-05-09 15:58:52,742 - INFO [GarbageCollectorThread:GarbageCollectorThread@466] - Extracting entry log meta from entryLogId: 0
> 2012-05-09 15:58:52,743 - WARN [GarbageCollectorThread:EntryLogger@386] - Failed to get channel to scan entry log: 0.log
> 2012-05-09 15:58:52,743 - WARN [GarbageCollectorThread:GarbageCollectorThread@473] - Premature exception when processing 0recovery will take care of the problem
> java.io.FileNotFoundException: No file for log 0
> at org.apache.bookkeeper.bookie.EntryLogger.findFile(EntryLogger.java:366)
> at org.apache.bookkeeper.bookie.EntryLogger.getChannelForLogId(EntryLogger.java:340)
> at org.apache.bookkeeper.bookie.EntryLogger.scanEntryLog(EntryLogger.java:384)
> at org.apache.bookkeeper.bookie.GarbageCollectorThread.extractMetaFromEntryLog(GarbageCollectorThread.java:485)
> at org.apache.bookkeeper.bookie.GarbageCollectorThread.extractMetaFromEntryLogs(GarbageCollectorThread.java:470)
> at org.apache.bookkeeper.bookie.GarbageCollectorThread.run(GarbageCollectorThread.java:189)
> {quote}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-251) Noise error message printed
when scanning entry log files those have been garbage collected.
Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272308#comment-13272308 ]
Flavio Junqueira commented on BOOKKEEPER-251:
---------------------------------------------
Thanks for the clarifications, Sijie.
{noformat}
Premature exception when processing 0recovery will take care of the problem
{noformat}
Two things that confuse me in this message:
# "Premature" indicates that the exception is coming at the wrong time. I believe we mean to say that garbage-collection has ended prematurely.
# "recovery should take care of it" does not make clear if any action is required from the operator. We may want to make it clear.
> Noise error message printed when scanning entry log files those have been garbage collected.
> --------------------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-251
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-251
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-server
> Affects Versions: 4.1.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.1.0
>
> Attachments: BK-251.diff
>
>
> currently, due to the messy scan mechanism deployed by garbage collector thread. following noise error message would be printed when scanning those entry log files has been garbage collected.
> {quote}
> 2012-05-09 15:58:52,742 - INFO [GarbageCollectorThread:GarbageCollectorThread@466] - Extracting entry log meta from entryLogId: 0
> 2012-05-09 15:58:52,743 - WARN [GarbageCollectorThread:EntryLogger@386] - Failed to get channel to scan entry log: 0.log
> 2012-05-09 15:58:52,743 - WARN [GarbageCollectorThread:GarbageCollectorThread@473] - Premature exception when processing 0recovery will take care of the problem
> java.io.FileNotFoundException: No file for log 0
> at org.apache.bookkeeper.bookie.EntryLogger.findFile(EntryLogger.java:366)
> at org.apache.bookkeeper.bookie.EntryLogger.getChannelForLogId(EntryLogger.java:340)
> at org.apache.bookkeeper.bookie.EntryLogger.scanEntryLog(EntryLogger.java:384)
> at org.apache.bookkeeper.bookie.GarbageCollectorThread.extractMetaFromEntryLog(GarbageCollectorThread.java:485)
> at org.apache.bookkeeper.bookie.GarbageCollectorThread.extractMetaFromEntryLogs(GarbageCollectorThread.java:470)
> at org.apache.bookkeeper.bookie.GarbageCollectorThread.run(GarbageCollectorThread.java:189)
> {quote}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-251) Noise error message printed
when scanning entry log files those have been garbage collected.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13277994#comment-13277994 ]
Hudson commented on BOOKKEEPER-251:
-----------------------------------
Integrated in bookkeeper-trunk #516 (See [https://builds.apache.org/job/bookkeeper-trunk/516/])
BOOKKEEPER-251: Noise error message printed when scanning entry log files those have been garbage collected. (sijie via ivank) (Revision 1339715)
Result = UNSTABLE
ivank :
Files :
* /zookeeper/bookkeeper/trunk/CHANGES.txt
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java
> Noise error message printed when scanning entry log files those have been garbage collected.
> --------------------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-251
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-251
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-server
> Affects Versions: 4.1.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.1.0
>
> Attachments: BK-251.diff, BK-251.diff_v2, BK-251.diff_v3
>
>
> currently, due to the messy scan mechanism deployed by garbage collector thread. following noise error message would be printed when scanning those entry log files has been garbage collected.
> {quote}
> 2012-05-09 15:58:52,742 - INFO [GarbageCollectorThread:GarbageCollectorThread@466] - Extracting entry log meta from entryLogId: 0
> 2012-05-09 15:58:52,743 - WARN [GarbageCollectorThread:EntryLogger@386] - Failed to get channel to scan entry log: 0.log
> 2012-05-09 15:58:52,743 - WARN [GarbageCollectorThread:GarbageCollectorThread@473] - Premature exception when processing 0recovery will take care of the problem
> java.io.FileNotFoundException: No file for log 0
> at org.apache.bookkeeper.bookie.EntryLogger.findFile(EntryLogger.java:366)
> at org.apache.bookkeeper.bookie.EntryLogger.getChannelForLogId(EntryLogger.java:340)
> at org.apache.bookkeeper.bookie.EntryLogger.scanEntryLog(EntryLogger.java:384)
> at org.apache.bookkeeper.bookie.GarbageCollectorThread.extractMetaFromEntryLog(GarbageCollectorThread.java:485)
> at org.apache.bookkeeper.bookie.GarbageCollectorThread.extractMetaFromEntryLogs(GarbageCollectorThread.java:470)
> at org.apache.bookkeeper.bookie.GarbageCollectorThread.run(GarbageCollectorThread.java:189)
> {quote}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-251) Noise error message printed
when scanning entry log files those have been garbage collected.
Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273003#comment-13273003 ]
Sijie Guo commented on BOOKKEEPER-251:
--------------------------------------
@Flavio,
actually this exception is related to issue BOOKKEEPER-126. currently we don't have such mechanism to handle corruption entry log files, so I think it is a 'Premature exception', the message is not so bad now.
I think one thing to do is adding a TODO item, so when we fix BOOKKEEPER-126. the message might need to be improved.
> Noise error message printed when scanning entry log files those have been garbage collected.
> --------------------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-251
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-251
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-server
> Affects Versions: 4.1.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.1.0
>
> Attachments: BK-251.diff
>
>
> currently, due to the messy scan mechanism deployed by garbage collector thread. following noise error message would be printed when scanning those entry log files has been garbage collected.
> {quote}
> 2012-05-09 15:58:52,742 - INFO [GarbageCollectorThread:GarbageCollectorThread@466] - Extracting entry log meta from entryLogId: 0
> 2012-05-09 15:58:52,743 - WARN [GarbageCollectorThread:EntryLogger@386] - Failed to get channel to scan entry log: 0.log
> 2012-05-09 15:58:52,743 - WARN [GarbageCollectorThread:GarbageCollectorThread@473] - Premature exception when processing 0recovery will take care of the problem
> java.io.FileNotFoundException: No file for log 0
> at org.apache.bookkeeper.bookie.EntryLogger.findFile(EntryLogger.java:366)
> at org.apache.bookkeeper.bookie.EntryLogger.getChannelForLogId(EntryLogger.java:340)
> at org.apache.bookkeeper.bookie.EntryLogger.scanEntryLog(EntryLogger.java:384)
> at org.apache.bookkeeper.bookie.GarbageCollectorThread.extractMetaFromEntryLog(GarbageCollectorThread.java:485)
> at org.apache.bookkeeper.bookie.GarbageCollectorThread.extractMetaFromEntryLogs(GarbageCollectorThread.java:470)
> at org.apache.bookkeeper.bookie.GarbageCollectorThread.run(GarbageCollectorThread.java:189)
> {quote}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-251) Noise error message printed
when scanning entry log files those have been garbage collected.
Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272270#comment-13272270 ]
Flavio Junqueira commented on BOOKKEEPER-251:
---------------------------------------------
Sijie, Could you comment a bit on how we reach this situation? I'm not entirely sure what the expected behavior is here. If the file has been garbage-collected, then why are we going over it again? Can we remember somehow what we have already garbage-collected?
We probably want to fix the log messages too. Messages like this do not a very good hint of what is going on:
{noformat}
2012-05-09 15:58:52,743 - WARN [GarbageCollectorThread:GarbageCollectorThread@473] - Premature exception when processing 0recovery will take care of the problem
{noformat}
> Noise error message printed when scanning entry log files those have been garbage collected.
> --------------------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-251
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-251
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-server
> Affects Versions: 4.1.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.1.0
>
> Attachments: BK-251.diff
>
>
> currently, due to the messy scan mechanism deployed by garbage collector thread. following noise error message would be printed when scanning those entry log files has been garbage collected.
> {quote}
> 2012-05-09 15:58:52,742 - INFO [GarbageCollectorThread:GarbageCollectorThread@466] - Extracting entry log meta from entryLogId: 0
> 2012-05-09 15:58:52,743 - WARN [GarbageCollectorThread:EntryLogger@386] - Failed to get channel to scan entry log: 0.log
> 2012-05-09 15:58:52,743 - WARN [GarbageCollectorThread:GarbageCollectorThread@473] - Premature exception when processing 0recovery will take care of the problem
> java.io.FileNotFoundException: No file for log 0
> at org.apache.bookkeeper.bookie.EntryLogger.findFile(EntryLogger.java:366)
> at org.apache.bookkeeper.bookie.EntryLogger.getChannelForLogId(EntryLogger.java:340)
> at org.apache.bookkeeper.bookie.EntryLogger.scanEntryLog(EntryLogger.java:384)
> at org.apache.bookkeeper.bookie.GarbageCollectorThread.extractMetaFromEntryLog(GarbageCollectorThread.java:485)
> at org.apache.bookkeeper.bookie.GarbageCollectorThread.extractMetaFromEntryLogs(GarbageCollectorThread.java:470)
> at org.apache.bookkeeper.bookie.GarbageCollectorThread.run(GarbageCollectorThread.java:189)
> {quote}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-251) Noise error message printed
when scanning entry log files those have been garbage collected.
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276829#comment-13276829 ]
Ivan Kelly commented on BOOKKEEPER-251:
---------------------------------------
Sijie, could you upload the new patch. The patch that is there seems to be the old one.
The TODO is fine with me.
> Noise error message printed when scanning entry log files those have been garbage collected.
> --------------------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-251
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-251
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-server
> Affects Versions: 4.1.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.1.0
>
> Attachments: BK-251.diff
>
>
> currently, due to the messy scan mechanism deployed by garbage collector thread. following noise error message would be printed when scanning those entry log files has been garbage collected.
> {quote}
> 2012-05-09 15:58:52,742 - INFO [GarbageCollectorThread:GarbageCollectorThread@466] - Extracting entry log meta from entryLogId: 0
> 2012-05-09 15:58:52,743 - WARN [GarbageCollectorThread:EntryLogger@386] - Failed to get channel to scan entry log: 0.log
> 2012-05-09 15:58:52,743 - WARN [GarbageCollectorThread:GarbageCollectorThread@473] - Premature exception when processing 0recovery will take care of the problem
> java.io.FileNotFoundException: No file for log 0
> at org.apache.bookkeeper.bookie.EntryLogger.findFile(EntryLogger.java:366)
> at org.apache.bookkeeper.bookie.EntryLogger.getChannelForLogId(EntryLogger.java:340)
> at org.apache.bookkeeper.bookie.EntryLogger.scanEntryLog(EntryLogger.java:384)
> at org.apache.bookkeeper.bookie.GarbageCollectorThread.extractMetaFromEntryLog(GarbageCollectorThread.java:485)
> at org.apache.bookkeeper.bookie.GarbageCollectorThread.extractMetaFromEntryLogs(GarbageCollectorThread.java:470)
> at org.apache.bookkeeper.bookie.GarbageCollectorThread.run(GarbageCollectorThread.java:189)
> {quote}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-251) Noise error message printed
when scanning entry log files those have been garbage collected.
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272239#comment-13272239 ]
Ivan Kelly commented on BOOKKEEPER-251:
---------------------------------------
The shape/functionality of the patch are good. I have a few comments on the names though. I think it would be clearer to name isLogExisted() as a) logExists() or b) doesLogExist(). I prefer a).
> Noise error message printed when scanning entry log files those have been garbage collected.
> --------------------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-251
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-251
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-server
> Affects Versions: 4.1.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.1.0
>
> Attachments: BK-251.diff
>
>
> currently, due to the messy scan mechanism deployed by garbage collector thread. following noise error message would be printed when scanning those entry log files has been garbage collected.
> {quote}
> 2012-05-09 15:58:52,742 - INFO [GarbageCollectorThread:GarbageCollectorThread@466] - Extracting entry log meta from entryLogId: 0
> 2012-05-09 15:58:52,743 - WARN [GarbageCollectorThread:EntryLogger@386] - Failed to get channel to scan entry log: 0.log
> 2012-05-09 15:58:52,743 - WARN [GarbageCollectorThread:GarbageCollectorThread@473] - Premature exception when processing 0recovery will take care of the problem
> java.io.FileNotFoundException: No file for log 0
> at org.apache.bookkeeper.bookie.EntryLogger.findFile(EntryLogger.java:366)
> at org.apache.bookkeeper.bookie.EntryLogger.getChannelForLogId(EntryLogger.java:340)
> at org.apache.bookkeeper.bookie.EntryLogger.scanEntryLog(EntryLogger.java:384)
> at org.apache.bookkeeper.bookie.GarbageCollectorThread.extractMetaFromEntryLog(GarbageCollectorThread.java:485)
> at org.apache.bookkeeper.bookie.GarbageCollectorThread.extractMetaFromEntryLogs(GarbageCollectorThread.java:470)
> at org.apache.bookkeeper.bookie.GarbageCollectorThread.run(GarbageCollectorThread.java:189)
> {quote}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-251) Noise error message printed when
scanning entry log files those have been garbage collected.
Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sijie Guo updated BOOKKEEPER-251:
---------------------------------
Attachment: BK-251.diff_v2
brought the patch to latest trunk
> Noise error message printed when scanning entry log files those have been garbage collected.
> --------------------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-251
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-251
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-server
> Affects Versions: 4.1.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.1.0
>
> Attachments: BK-251.diff, BK-251.diff_v2
>
>
> currently, due to the messy scan mechanism deployed by garbage collector thread. following noise error message would be printed when scanning those entry log files has been garbage collected.
> {quote}
> 2012-05-09 15:58:52,742 - INFO [GarbageCollectorThread:GarbageCollectorThread@466] - Extracting entry log meta from entryLogId: 0
> 2012-05-09 15:58:52,743 - WARN [GarbageCollectorThread:EntryLogger@386] - Failed to get channel to scan entry log: 0.log
> 2012-05-09 15:58:52,743 - WARN [GarbageCollectorThread:GarbageCollectorThread@473] - Premature exception when processing 0recovery will take care of the problem
> java.io.FileNotFoundException: No file for log 0
> at org.apache.bookkeeper.bookie.EntryLogger.findFile(EntryLogger.java:366)
> at org.apache.bookkeeper.bookie.EntryLogger.getChannelForLogId(EntryLogger.java:340)
> at org.apache.bookkeeper.bookie.EntryLogger.scanEntryLog(EntryLogger.java:384)
> at org.apache.bookkeeper.bookie.GarbageCollectorThread.extractMetaFromEntryLog(GarbageCollectorThread.java:485)
> at org.apache.bookkeeper.bookie.GarbageCollectorThread.extractMetaFromEntryLogs(GarbageCollectorThread.java:470)
> at org.apache.bookkeeper.bookie.GarbageCollectorThread.run(GarbageCollectorThread.java:189)
> {quote}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira