[GitHub] [hudi] danny0405 commented on a diff in pull request #7469: [HUDI-5386] Cleaning conflicts when write concurrency mode is OCC

[GitBox <gi...@apache.org>]

danny0405 commented on code in PR #7469:
URL: https://github.com/apache/hudi/pull/7469#discussion_r1060339901


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -897,28 +897,40 @@ public HoodieCleanMetadata clean(String cleanInstantTime, boolean scheduleInline
     if (!tableServicesEnabled(config)) {
       return null;
     }
-    final Timer.Context timerContext = metrics.getCleanCtx();
-    CleanerUtils.rollbackFailedWrites(config.getFailedWritesCleanPolicy(),
-        HoodieTimeline.CLEAN_ACTION, () -> rollbackFailedWrites(skipLocking));
-
-    HoodieTable table = createTable(config, hadoopConf);
-    if (config.allowMultipleCleans() || !table.getActiveTimeline().getCleanerTimeline().filterInflightsAndRequested().firstInstant().isPresent()) {
-      LOG.info("Cleaner started");

Review Comment:
   I'm worrying about the efficiency. It is not that efficient for concurrent cleaning and not that necessary.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org