[GitHub] [hadoop-ozone] xiaoyuyao commented on a change in pull request #1264: HDDS-4035. Update logs of HadoopDirGenerator.

[GitBox <gi...@apache.org>]

xiaoyuyao commented on a change in pull request #1264:
URL: https://github.com/apache/hadoop-ozone/pull/1264#discussion_r463393431



##########
File path: hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/BaseFreonGenerator.java
##########
@@ -301,6 +301,18 @@ public void printReport() {
     messages.forEach(print);
   }
 
+  /**
+   * Print out reports with the given message.
+   */
+  public void print(String msg){
+    List<String> messages = new LinkedList<>();
+    messages.add(msg);

Review comment:
       Given we only have one String msg here, we can eliminate thew List allocation here by just simply call
   print.accept(msg) in line 313. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org