You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@activemq.apache.org by ro...@apache.org on 2023/04/03 08:27:30 UTC

[activemq-artemis] 04/04: ARTEMIS-4229 Upgrade selenium version to 4.8.3

This is an automated email from the ASF dual-hosted git repository.

robbie pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/activemq-artemis.git

commit ff87b9c5cb99c12cb5f436d4627cadabdfcb16c4
Author: Domenico Francesco Bruscino <br...@apache.org>
AuthorDate: Fri Mar 31 18:51:29 2023 +0200

    ARTEMIS-4229 Upgrade selenium version to 4.8.3
---
 tests/smoke-tests/pom.xml                                             | 2 +-
 .../org/apache/activemq/artemis/tests/smoke/console/ConsoleTest.java  | 2 +-
 .../activemq/artemis/tests/smoke/console/pages/ConsolePage.java       | 4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/tests/smoke-tests/pom.xml b/tests/smoke-tests/pom.xml
index 3cee5d826f..353e501d16 100644
--- a/tests/smoke-tests/pom.xml
+++ b/tests/smoke-tests/pom.xml
@@ -114,7 +114,7 @@
       <dependency>
          <groupId>org.seleniumhq.selenium</groupId>
          <artifactId>selenium-java</artifactId>
-         <version>3.141.59</version>
+         <version>4.8.3</version>
          <scope>test</scope>
       </dependency>
 
diff --git a/tests/smoke-tests/src/test/java/org/apache/activemq/artemis/tests/smoke/console/ConsoleTest.java b/tests/smoke-tests/src/test/java/org/apache/activemq/artemis/tests/smoke/console/ConsoleTest.java
index 1fe659c4e3..74c57438ea 100644
--- a/tests/smoke-tests/src/test/java/org/apache/activemq/artemis/tests/smoke/console/ConsoleTest.java
+++ b/tests/smoke-tests/src/test/java/org/apache/activemq/artemis/tests/smoke/console/ConsoleTest.java
@@ -156,7 +156,7 @@ public abstract class ConsoleTest extends SmokeTestBase {
 
       // Wait for server console
       WebDriverWait loadWebDriverWait = new WebDriverWait(
-         driver, Duration.ofMillis(30000).getSeconds());
+         driver, Duration.ofMillis(30000));
 
       logger.info("Loading " + webServerUrl);
       loadWebDriverWait.until((Function<WebDriver, Object>) webDriver -> {
diff --git a/tests/smoke-tests/src/test/java/org/apache/activemq/artemis/tests/smoke/console/pages/ConsolePage.java b/tests/smoke-tests/src/test/java/org/apache/activemq/artemis/tests/smoke/console/pages/ConsolePage.java
index aba68e4576..0b4ebf3228 100644
--- a/tests/smoke-tests/src/test/java/org/apache/activemq/artemis/tests/smoke/console/pages/ConsolePage.java
+++ b/tests/smoke-tests/src/test/java/org/apache/activemq/artemis/tests/smoke/console/pages/ConsolePage.java
@@ -55,14 +55,14 @@ public abstract class ConsolePage {
 
    public void waitForElementToBeVisible(final By elementLocator, int timeout) {
       WebDriverWait loadWebDriverWait = new WebDriverWait(
-         driver, Duration.ofMillis(timeout).getSeconds());
+         driver, Duration.ofMillis(timeout));
 
       loadWebDriverWait.until(ExpectedConditions.visibilityOfElementLocated(elementLocator));
    }
 
    public void waitForElementToBeClickable(final By elementLocator, int timeout) {
       WebDriverWait loadWebDriverWait = new WebDriverWait(
-         driver, Duration.ofMillis(timeout).getSeconds());
+         driver, Duration.ofMillis(timeout));
 
       loadWebDriverWait.until(ExpectedConditions.elementToBeClickable(elementLocator));
    }